From f3bb71206c4b378accd94d8e3ff919767de42936 Mon Sep 17 00:00:00 2001 From: David Ostrovsky Date: Fri, 2 Oct 2020 18:49:21 +0200 Subject: Fix OperatorPrecedence warning flagged by error prone Building with Bazel is failing with this error message: HttpSupport.java:480: error: [OperatorPrecedence] Use grouping parenthesis to make the operator precedence explicit if (c >= 'a' && c <= 'z' || c >= 'A' && c <= 'Z') { ^ (see https://errorprone.info/bugpattern/OperatorPrecedence) Did you mean 'if ((c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z')) {'? Change-Id: I96089d3158d06ba981cfdf2b03865261b328de23 --- org.eclipse.jgit/src/org/eclipse/jgit/util/HttpSupport.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/util/HttpSupport.java b/org.eclipse.jgit/src/org/eclipse/jgit/util/HttpSupport.java index 03672f8ba5..04b3eab504 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/util/HttpSupport.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/util/HttpSupport.java @@ -477,7 +477,7 @@ public class HttpSupport { i++; break; default: - if (c >= 'a' && c <= 'z' || c >= 'A' && c <= 'Z') { + if ((c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z')) { i++; break; } -- cgit v1.2.3