From 2e652aebab329e805beb8198dea6a064bd64ec1f Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Fri, 22 Jul 2016 17:21:20 +0900 Subject: FileLfsServlet: Return HTTP 422 instead of 400 According to the specification [1], the error response status code should be 422 when there is a validation error with one or more of the objects in the request [1] https://github.com/github/git-lfs/blob/master/docs/api/v1/http-v1-batch.md#response-errors Change-Id: Id03fe00a2109b896d9a154228a14a33bce5accc3 Signed-off-by: David Pursehouse --- .../src/org/eclipse/jgit/lfs/server/fs/FileLfsServlet.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'org.eclipse.jgit.lfs.server/src/org/eclipse/jgit') diff --git a/org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/fs/FileLfsServlet.java b/org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/fs/FileLfsServlet.java index 586941357a..925dea8de5 100644 --- a/org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/fs/FileLfsServlet.java +++ b/org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/fs/FileLfsServlet.java @@ -121,14 +121,14 @@ public class FileLfsServlet extends HttpServlet { HttpServletResponse rsp) throws IOException { String info = req.getPathInfo(); if (info.length() != 1 + Constants.LONG_OBJECT_ID_STRING_LENGTH) { - sendError(rsp, HttpStatus.SC_BAD_REQUEST, MessageFormat + sendError(rsp, HttpStatus.SC_UNPROCESSABLE_ENTITY, MessageFormat .format(LfsServerText.get().invalidPathInfo, info)); return null; } try { return LongObjectId.fromString(info.substring(1, 65)); } catch (InvalidLongObjectIdException e) { - sendError(rsp, HttpStatus.SC_BAD_REQUEST, e.getMessage()); + sendError(rsp, HttpStatus.SC_UNPROCESSABLE_ENTITY, e.getMessage()); return null; } } -- cgit v1.2.3