From c54ff8bf123835e1e9592fcef799bafce9423a94 Mon Sep 17 00:00:00 2001 From: Matthias Sohn Date: Thu, 19 May 2016 14:50:12 +0200 Subject: [findBugs] Fix calculation of host header in SignerV4 We ignored the returned concatenation of host name and port number. Fix this and use a StringBuilder to avoid creation of unnecessary String objects. Change-Id: I61fac639d4a4c95412eb41a0f9131d0c38aca794 Signed-off-by: Matthias Sohn --- .../src/org/eclipse/jgit/lfs/server/s3/SignerV4.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'org.eclipse.jgit.lfs.server/src') diff --git a/org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/s3/SignerV4.java b/org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/s3/SignerV4.java index 08bb4b96fd..f95b605c85 100644 --- a/org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/s3/SignerV4.java +++ b/org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/s3/SignerV4.java @@ -229,12 +229,12 @@ class SignerV4 { private static void addHostHeader(URL url, Map headers) { - String hostHeader = url.getHost(); + StringBuilder hostHeader = new StringBuilder(url.getHost()); int port = url.getPort(); if (port > -1) { - hostHeader.concat(":" + Integer.toString(port)); //$NON-NLS-1$ + hostHeader.append(":").append(port); //$NON-NLS-1$ } - headers.put("Host", hostHeader); //$NON-NLS-1$ + headers.put("Host", hostHeader.toString()); //$NON-NLS-1$ } private static String canonicalizeHeaderNames( -- cgit v1.2.3