From 38eec8f4a26935ba9e75bfbdde8a5682e05f338d Mon Sep 17 00:00:00 2001 From: Matthias Sohn Date: Fri, 10 Dec 2010 21:58:05 +0100 Subject: [findbugs] Do not ignore exceptional return value of mkdir java.io.File.mkdir() and mkdirs() report failure as an exceptional return value false. Fix the code which silently ignored this exceptional return value. Change-Id: I41244f4b9d66176e68e2c07e2329cf08492f8619 Signed-off-by: Matthias Sohn --- org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/eclipse/Iplog.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'org.eclipse.jgit.pgm/src') diff --git a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/eclipse/Iplog.java b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/eclipse/Iplog.java index 84859a805c..86b93a0f84 100644 --- a/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/eclipse/Iplog.java +++ b/org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/eclipse/Iplog.java @@ -59,6 +59,7 @@ import org.eclipse.jgit.revwalk.RevObject; import org.eclipse.jgit.revwalk.RevTag; import org.eclipse.jgit.revwalk.RevWalk; import org.eclipse.jgit.storage.file.LockFile; +import org.eclipse.jgit.util.FileUtils; import org.kohsuke.args4j.Argument; import org.kohsuke.args4j.Option; @@ -96,8 +97,7 @@ class Iplog extends TextBuiltin { log.scan(db, rw.parseCommit(start), version); if (output != null) { - if (!output.getParentFile().exists()) - output.getParentFile().mkdirs(); + FileUtils.mkdirs(output.getParentFile(), true); LockFile lf = new LockFile(output, db.getFS()); if (!lf.lock()) throw die(MessageFormat.format(CLIText.get().cannotLock, output)); -- cgit v1.2.3