From 773f9661d0634fb3ad69466c0f0ec4d65cb2122d Mon Sep 17 00:00:00 2001 From: Dave Borowitz Date: Fri, 29 Apr 2016 10:47:17 -0400 Subject: PersonIdent: Document that name and email aren't trimmed This might be somewhat surprising behavior to users who might naturally assume the following invariant: ident.equals(parseIdent(ident.toExternalString())) This invariant does not hold since whitespace is only trimmed during serialization. We don't want to mess with the strings during initialization, as this is called during the highly-optimized commit parsing codepath. Change-Id: I081a603f0ac0e33167462244779b0ff3ad51e80c --- .../tst/org/eclipse/jgit/lib/T0001_PersonIdentTest.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'org.eclipse.jgit.test/tst/org/eclipse/jgit/lib') diff --git a/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/T0001_PersonIdentTest.java b/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/T0001_PersonIdentTest.java index 1515a07ac4..48d2c480a9 100644 --- a/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/T0001_PersonIdentTest.java +++ b/org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/T0001_PersonIdentTest.java @@ -92,8 +92,10 @@ public class T0001_PersonIdentTest { PersonIdent personIdent = new PersonIdent(" A U Thor ", " author@example.com "); - String externalString = personIdent.toExternalString(); + assertEquals(" A U Thor ", personIdent.getName()); + assertEquals(" author@example.com ", personIdent.getEmailAddress()); + String externalString = personIdent.toExternalString(); assertTrue(externalString.startsWith("A U Thor ")); } -- cgit v1.2.3