From 428d31efd305b08e83dbd9fdd895d18dc232c295 Mon Sep 17 00:00:00 2001 From: Andrey Loskutov Date: Tue, 6 Jan 2015 14:33:07 +0100 Subject: AIOOB in ChangeIdUtil.indexOfChangeId if amended message is a newline Bug: 456792 Change-Id: Idf38a0db7dc72d672ff185dcac2f41f0012a6673 Signed-off-by: Andrey Loskutov --- org.eclipse.jgit.test/tst/org/eclipse/jgit/util/ChangeIdUtilTest.java | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'org.eclipse.jgit.test') diff --git a/org.eclipse.jgit.test/tst/org/eclipse/jgit/util/ChangeIdUtilTest.java b/org.eclipse.jgit.test/tst/org/eclipse/jgit/util/ChangeIdUtilTest.java index 66649b1006..7273cdbabc 100644 --- a/org.eclipse.jgit.test/tst/org/eclipse/jgit/util/ChangeIdUtilTest.java +++ b/org.eclipse.jgit.test/tst/org/eclipse/jgit/util/ChangeIdUtilTest.java @@ -639,6 +639,10 @@ public class ChangeIdUtilTest { @Test public void testIndexOfChangeId() { + assertEquals(-1, ChangeIdUtil.indexOfChangeId("", "\n")); + assertEquals(-1, ChangeIdUtil.indexOfChangeId("\n", "\n")); + assertEquals(-1, ChangeIdUtil.indexOfChangeId("\r\n", "\r\n")); + assertEquals(3, ChangeIdUtil.indexOfChangeId("x\n" + "\n" + "Change-Id: I3b7e4e16b503ce00f07ba6ad01d97a356dad7701\n", "\n")); -- cgit v1.2.3