From 7ac182f4e427e0d5a986b8ca67a56fc22828b1a0 Mon Sep 17 00:00:00 2001 From: David Pursehouse Date: Mon, 16 Jan 2017 14:39:32 +0900 Subject: Enable and fix 'Should be tagged with @Override' warning Set missingOverrideAnnotation=warning in Eclipse compiler preferences which enables the warning: The method of type should be tagged with @Override since it actually overrides a superclass method Justification for this warning is described in: http://stackoverflow.com/a/94411/381622 Enabling this causes in excess of 1000 warnings across the entire code-base. They are very easy to fix automatically with Eclipse's "Quick Fix" tool. Fix all of them except 2 which cause compilation failure when the project is built with mvn; add TODO comments on those for further investigation. Change-Id: I5772061041fd361fe93137fd8b0ad356e748a29c Signed-off-by: David Pursehouse --- org.eclipse.jgit/src/org/eclipse/jgit/transport/URIish.java | 3 +++ 1 file changed, 3 insertions(+) (limited to 'org.eclipse.jgit/src/org/eclipse/jgit/transport/URIish.java') diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/transport/URIish.java b/org.eclipse.jgit/src/org/eclipse/jgit/transport/URIish.java index 3c5c8daddd..ffd4d41f2a 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/transport/URIish.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/transport/URIish.java @@ -560,6 +560,7 @@ public class URIish implements Serializable { return r; } + @Override public int hashCode() { int hc = 0; if (getScheme() != null) @@ -577,6 +578,7 @@ public class URIish implements Serializable { return hc; } + @Override public boolean equals(final Object obj) { if (!(obj instanceof URIish)) return false; @@ -615,6 +617,7 @@ public class URIish implements Serializable { return format(true, false); } + @Override public String toString() { return format(false, false); } -- cgit v1.2.3