From bac4d32d39abc6fb9af61628adbed139ea442ee9 Mon Sep 17 00:00:00 2001
From: Hector Caballero <hector.caballero@ericsson.com>
Date: Fri, 3 Nov 2017 14:39:37 -0400
Subject: GC: Delete stale temporary packs and indexes

When a GC operation is interrupted, temporary packs and indexes can be
left on the pack folder. In big, busy repositories this can lead to
significant amounts of wasted disk space if this interruption is done
with a certain frequency.

Remove stale temporary packs and indexes at the end of the GC process so
they do not accumulate. To avoid interfering with a possible concurrent
JGit GC process in the same repository, only delete temporary files that
are older than one day.

Change-Id: If9b6c1e57fac8a6a0ecc0a703089634caba4caae
Signed-off-by: Hector Caballero <hector.caballero@ericsson.com>
---
 .../org/eclipse/jgit/internal/storage/file/GC.java | 25 ++++++++++++++++++++++
 1 file changed, 25 insertions(+)

(limited to 'org.eclipse.jgit/src')

diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/GC.java b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/GC.java
index f992a33408..928e52d6b4 100644
--- a/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/GC.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/GC.java
@@ -61,6 +61,8 @@ import java.nio.file.Paths;
 import java.nio.file.StandardCopyOption;
 import java.text.MessageFormat;
 import java.text.ParseException;
+import java.time.Instant;
+import java.time.temporal.ChronoUnit;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
@@ -903,6 +905,7 @@ public class GC {
 		}
 		prunePacked();
 		deleteOrphans();
+		deleteTempPacksIdx();
 
 		lastPackedRefs = refsBefore;
 		lastRepackTime = time;
@@ -959,6 +962,28 @@ public class GC {
 		}
 	}
 
+	private void deleteTempPacksIdx() {
+		Path packDir = Paths.get(repo.getObjectsDirectory().getAbsolutePath(),
+				"pack"); //$NON-NLS-1$
+		Instant threshold = Instant.now().minus(1, ChronoUnit.DAYS);
+		try {
+			Files.newDirectoryStream(packDir, "gc_*_tmp") //$NON-NLS-1$
+					.forEach(t -> {
+						try {
+							Instant lastModified = Files.getLastModifiedTime(t)
+									.toInstant();
+							if (lastModified.isBefore(threshold)) {
+								Files.deleteIfExists(t);
+							}
+						} catch (IOException e) {
+							LOG.error(e.getMessage(), e);
+						}
+					});
+		} catch (IOException e) {
+			LOG.error(e.getMessage(), e);
+		}
+	}
+
 	/**
 	 * @param ref
 	 *            the ref which log should be inspected
-- 
cgit v1.2.3