diff options
author | Jörn Zaefferer <joern.zaefferer@gmail.com> | 2013-06-14 09:01:02 +0200 |
---|---|---|
committer | Jörn Zaefferer <joern.zaefferer@gmail.com> | 2013-07-03 16:01:51 +0200 |
commit | 7da828375afb20d58736bb1eb530f915c445d5b9 (patch) | |
tree | f9a1223e6c4de203447e6974d0e88b98e66aef28 | |
parent | 4ed52cba6555660268210ef76c38101d9dfef8df (diff) | |
download | jquery-ui-7da828375afb20d58736bb1eb530f915c445d5b9.tar.gz jquery-ui-7da828375afb20d58736bb1eb530f915c445d5b9.zip |
Build: Implement an asciilint task to verify content of ui files (ignore i18n). Fixes #9037 - Build: Verify characters in output
-rw-r--r-- | Gruntfile.js | 2 | ||||
-rw-r--r-- | build/tasks/build.js | 33 |
2 files changed, 34 insertions, 1 deletions
diff --git a/Gruntfile.js b/Gruntfile.js index 4eee9a1ab..b35a4514d 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -244,7 +244,7 @@ grunt.initConfig({ }); grunt.registerTask( "default", [ "lint", "test" ] ); -grunt.registerTask( "lint", [ "jshint", "csslint", "htmllint" ] ); +grunt.registerTask( "lint", [ "asciilint", "jshint", "csslint", "htmllint" ] ); grunt.registerTask( "test", [ "qunit" ] ); grunt.registerTask( "sizer", [ "concat:ui", "uglify:main", "compare_size:all" ] ); grunt.registerTask( "sizer_all", [ "concat:ui", "uglify", "compare_size" ] ); diff --git a/build/tasks/build.js b/build/tasks/build.js index 4d803df77..c50745899 100644 --- a/build/tasks/build.js +++ b/build/tasks/build.js @@ -135,4 +135,37 @@ grunt.registerTask( "clean", function() { require( "rimraf" ).sync( "dist" ); }); +grunt.registerTask( "asciilint", function() { + var valid = true, + files = grunt.file.expand({ filter: "isFile" }, "ui/*.js" ); + files.forEach(function( filename ) { + var i, c, + text = grunt.file.read( filename ); + + // Ensure files use only \n for line endings, not \r\n + if ( /\x0d\x0a/.test( text ) ) { + grunt.log.error( filename + ": Incorrect line endings (\\r\\n)" ); + valid = false; + } + + // Ensure only ASCII chars so script tags don't need a charset attribute + if ( text.length !== Buffer.byteLength( text, "utf8" ) ) { + grunt.log.error( filename + ": Non-ASCII characters detected:" ); + for ( i = 0; i < text.length; i++ ) { + c = text.charCodeAt( i ); + if ( c > 127 ) { + grunt.log.error( "- position " + i + ": " + c ); + grunt.log.error( "-- " + text.substring( i - 20, i + 20 ) ); + break; + } + } + valid = false; + } + }); + if ( valid ) { + grunt.log.ok( files.length + " files lint free." ); + } + return valid; +}); + }; |