diff options
author | Scott González <scott.gonzalez@gmail.com> | 2015-03-23 18:42:23 -0400 |
---|---|---|
committer | Scott González <scott.gonzalez@gmail.com> | 2015-03-25 15:55:53 -0400 |
commit | 899d90709a141ce22fedab2cfdf6044d9928f831 (patch) | |
tree | 3ffc9ed66db142e5661586fa42083bb4bcb7cadd | |
parent | e109e768190089744804d084e9a26f010dd63a37 (diff) | |
download | jquery-ui-899d90709a141ce22fedab2cfdf6044d9928f831.tar.gz jquery-ui-899d90709a141ce22fedab2cfdf6044d9928f831.zip |
Tests: Handle jQuery git returning `null` for empty attributes
jQuery now returns `null` for empty attributes instead of `undefined`.
Closes gh-1516
-rw-r--r-- | tests/unit/core/core.js | 4 | ||||
-rw-r--r-- | tests/unit/dialog/dialog_core.js | 2 | ||||
-rw-r--r-- | tests/unit/menu/menu_options.js | 4 | ||||
-rw-r--r-- | tests/unit/progressbar/progressbar_core.js | 2 | ||||
-rw-r--r-- | tests/unit/tooltip/tooltip_core.js | 3 | ||||
-rw-r--r-- | tests/unit/tooltip/tooltip_methods.js | 2 |
6 files changed, 8 insertions, 9 deletions
diff --git a/tests/unit/core/core.js b/tests/unit/core/core.js index 2f3657605..a0d0a2de1 100644 --- a/tests/unit/core/core.js +++ b/tests/unit/core/core.js @@ -127,11 +127,11 @@ test( "outerHeight(true) - setter", function() { test( "uniqueId / removeUniqueId", function() { expect( 3 ); var el = $( "img" ).eq( 0 ); - strictEqual( el.attr( "id" ), undefined, "element has no initial id" ); + equal( el.attr( "id" ), null, "element has no initial id" ); el.uniqueId(); ok( /ui-id-\d+$/.test( el.attr( "id" ) ), "element has generated id" ); el.removeUniqueId(); - strictEqual( el.attr( "id" ), undefined, "unique id has been removed from element" ); + equal( el.attr( "id" ), null, "unique id has been removed from element" ); }); })( jQuery ); diff --git a/tests/unit/dialog/dialog_core.js b/tests/unit/dialog/dialog_core.js index f600722fc..73d24fed0 100644 --- a/tests/unit/dialog/dialog_core.js +++ b/tests/unit/dialog/dialog_core.js @@ -78,7 +78,7 @@ test( "ARIA", function() { element.remove(); element = $("<div><div aria-describedby='section2'><p id='section2'>descriotion</p></div></div>").dialog(); - strictEqual( element.dialog( "widget" ).attr( "aria-describedby" ), undefined, "no aria-describedby added, as already present in markup" ); + equal( element.dialog( "widget" ).attr( "aria-describedby" ), null, "no aria-describedby added, as already present in markup" ); element.remove(); }); diff --git a/tests/unit/menu/menu_options.js b/tests/unit/menu/menu_options.js index 39ba62e3c..3df547334 100644 --- a/tests/unit/menu/menu_options.js +++ b/tests/unit/menu/menu_options.js @@ -107,11 +107,11 @@ test( "{ role: null }", function( assert ) { }), items = element.find( "li" ); expect( 2 + 3 * items.length ); - strictEqual( element.attr( "role" ), undefined ); + equal( element.attr( "role" ), null ); ok( items.length > 0, "number of menu items" ); items.each(function( item ) { assert.hasClasses( $( this ), "ui-menu-item" ); - equal( $( this ).find( ".ui-menu-item-wrapper" ).attr( "role" ), undefined, + equal( $( this ).find( ".ui-menu-item-wrapper" ).attr( "role" ), null, "menu item ("+ item + ") role" ); equal( $( this ).find( ".ui-menu-item-wrapper" ).attr( "tabindex" ), "-1", "tabindex for menu item ("+ item + ")" ); diff --git a/tests/unit/progressbar/progressbar_core.js b/tests/unit/progressbar/progressbar_core.js index 686e93b43..60ff31411 100644 --- a/tests/unit/progressbar/progressbar_core.js +++ b/tests/unit/progressbar/progressbar_core.js @@ -55,7 +55,7 @@ test( "accessibility", function() { element.progressbar( "option", "value", false ); equal( element.attr( "aria-valuemin" ), 0, "aria-valuemin" ); equal( element.attr( "aria-valuemax" ), 150, "aria-valuemax" ); - strictEqual( element.attr( "aria-valuenow" ), undefined, "aria-valuenow" ); + equal( element.attr( "aria-valuenow" ), null, "aria-valuenow" ); }); }( jQuery ) ); diff --git a/tests/unit/tooltip/tooltip_core.js b/tests/unit/tooltip/tooltip_core.js index 10ebb2829..d4520a4ea 100644 --- a/tests/unit/tooltip/tooltip_core.js +++ b/tests/unit/tooltip/tooltip_core.js @@ -38,8 +38,7 @@ test( "accessibility", function() { equal( element.attr( "aria-describedby" ), "fixture-span " + tooltipId, "multiple describedby when open" ); - // strictEqual to distinguish between .removeAttr( "title" ) and .attr( "title", "" ) - strictEqual( element.attr( "title" ), undefined, "no title when open" ); + equal( element.attr( "title" ), null, "no title when open" ); equal( liveRegion.children().length, 1 ); equal( liveRegion.children().last().html(), "..." ); element.tooltip( "close" ); diff --git a/tests/unit/tooltip/tooltip_methods.js b/tests/unit/tooltip/tooltip_methods.js index ea69216d0..f027d5226 100644 --- a/tests/unit/tooltip/tooltip_methods.js +++ b/tests/unit/tooltip/tooltip_methods.js @@ -70,7 +70,7 @@ test( "enable/disable", function( assert ) { assert.lacksClasses( element.tooltip( "widget" ), "ui-state-disabled" ); ok( !element.tooltip( "widget" ).attr( "aria-disabled" ), "element doesn't get aria-disabled" ); assert.lacksClasses( element.tooltip( "widget" ), "ui-tooltip-disabled" ); - strictEqual( tooltip.attr( "title" ), undefined, "title removed on disable" ); + equal( tooltip.attr( "title" ), null, "title removed on disable" ); element.tooltip( "open" ); equal( $( ".ui-tooltip" ).length, 0, "open does nothing when disabled" ); |