aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichał Gołębiowski-Owczarek <m.goleb@gmail.com>2020-07-23 15:51:15 +0200
committerGitHub <noreply@github.com>2020-07-23 15:51:15 +0200
commitb8ec78a37af50b95bab71416b8593e84b239fca7 (patch)
tree2aaca98c2cd7a9e2b28a5b034ce4b694b45741ff
parent42bcdb90f62399f74c9ad7abd08dcd8067525668 (diff)
downloadjquery-ui-b8ec78a37af50b95bab71416b8593e84b239fca7.tar.gz
jquery-ui-b8ec78a37af50b95bab71416b8593e84b239fca7.zip
Tests: Skip a scrollbar test in jQuery 3.2
jQuery 3.2 incorrectly handle scrollbars in WebKit/Blink-based browsers. This is fixed in version 3.3, see https://github.com/jquery/jquery/issues/3589. As the data here comes from jQuery directly and the changes to fix it are non-trivial: https://github.com/jquery/jquery/pull/3656, just accept that scrollbar data in this jQuery version is inaccurate. Closes gh-1927 Ref jquery/jquery#3589 Ref jquery/jquery#3656
-rw-r--r--tests/unit/position/core.js8
1 files changed, 7 insertions, 1 deletions
diff --git a/tests/unit/position/core.js b/tests/unit/position/core.js
index 80992a311..49f02afab 100644
--- a/tests/unit/position/core.js
+++ b/tests/unit/position/core.js
@@ -640,7 +640,13 @@ QUnit.test( "within", function( assert ) {
}, "flipfit - left top" );
} );
-QUnit.test( "with scrollbars", function( assert ) {
+// jQuery 3.2 incorrectly handle scrollbars in WebKit/Blink-based browsers.
+// This is fixed in version 3.3, see https://github.com/jquery/jquery/issues/3589.
+// As the data here comes from jQuery directly and the changes to fix it
+// are non-trivial: https://github.com/jquery/jquery/pull/3656, just accept
+// that scrollbar data in this jQuery version is inaccurate.
+QUnit[ jQuery.fn.jquery.substring( 0, 4 ) === "3.2." ? "skip" : "test" ](
+ "with scrollbars", function( assert ) {
assert.expect( 4 );
$( "#scrollx" ).css( {