Slider: Add missing unit test cases for values method

Closes gh-1573

1 files changed, 49 insertions, 3 deletions

diff --git a/tests/unit/slider/methods.js b/tests/unit/slider/methods.js
index 15b2e8726..5c0cbb7bd 100644
--- a/tests/unit/slider/methods.js
+++ b/tests/unit/slider/methods.js
@@ -111,8 +111,54 @@ test( "value", function() {
 	equal( element.slider( "value" ), 460, "value is restricted to maximum valid step" );
 } );
 
-//test( "values", function() {
-//	ok(false, "missing test - untested code is broken code." );
-//});
+test( "values, single step", function() {
+	expect( 8 );
+
+	var element = $( "<div></div>" ).slider( {
+		range: false,
+		min: 10,
+		max: 100,
+		step: 1,
+		values: [ 20 ]
+	} );
+
+	deepEqual( element.slider( "values" ), [ 20 ], "range: false, values - get value for handle" );
+	equal( element.slider( "values", 0 ), 20, "values (index) - get value of handle" );
+
+	element.slider( "values", 0, 5 );
+	equal( element.slider( "values", 0 ), 10, "values (index) - restrict against min" );
+
+	element.slider( "values", 0, 110 );
+	equal( element.slider( "values", 0 ), 100, "values (index) - restrict against max" );
+
+	element.slider( "option", "range", true );
+	element.slider( "values", [ 20, 90 ] );
+
+	deepEqual( element.slider( "values" ), [ 20, 90 ], "range: true, values - get value for all handles" );
+	equal( element.slider( "values", 0 ), 20, "values (index) - 1st handle" );
+	equal( element.slider( "values", 1 ), 90, "values (index) - 2nd handle" );
+
+	element.slider( "values", [ 5, 110 ] );
+	deepEqual( element.slider( "values" ), [ 10, 100 ], "values - restricted against min and max" );
+	element.slider( "destroy" );
+} );
+
+test( "values, multi step", function() {
+	expect( 2 );
+
+	var element = $( "<div></div>" ).slider( {
+		range: false,
+		min: 9,
+		max: 20,
+		step: 3,
+		values: [ 9, 12 ]
+	} );
+	deepEqual( element.slider( "values" ), [ 9, 12 ], "values - evenly divisible by step" );
+
+	element.slider( "values", [ 10, 20 ] );
+	deepEqual( element.slider( "values" ), [ 9, 18 ], "values - not evenly divisible by step" );
+
+	element.slider( "destroy" );
+} );
 
 } );

path: root/apps/files_sharing/lib/Controller/SettingsController.php

<?php

declare(strict_types=1);

/**
 * @copyright Copyright (c) 2019, Roeland Jago Douma <roeland@famdouma.nl>
 *
 * @author Roeland Jago Douma <roeland@famdouma.nl>
 * @author Hinrich Mahler <nextcloud@mahlerhome.de>
 *
 * @license GNU AGPL version 3 or any later version
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 *
 */
namespace OCA\Files_Sharing\Controller;

use OCA\Files_Sharing\AppInfo\Application;
use OCP\AppFramework\Controller;
use OCP\AppFramework\Http\JSONResponse;
use OCP\IConfig;
use OCP\IRequest;

class SettingsController extends Controller {

	/** @var IConfig */
	private $config;

	/** @var string */
	private $userId;

	public function __construct(IRequest $request,
								IConfig $config,
								string $userId) {
		parent::__construct(Application::APP_ID, $request);

		$this->config = $config;
		$this->userId = $userId;
	}

	/**
	 * @NoAdminRequired
	 */
	public function setDefaultAccept(bool $accept): JSONResponse {
		$this->config->setUserValue($this->userId, Application::APP_ID, 'default_accept', $accept ? 'yes' : 'no');
		return new JSONResponse();
	}

	/**
	 * @NoAdminRequired
	 */
	public function setUserShareFolder(string $shareFolder): JSONResponse {
		$this->config->setUserValue($this->userId, Application::APP_ID, 'share_folder', $shareFolder);
		return new JSONResponse();
	}

	/**
	 * @NoAdminRequired
	 */
	public function resetUserShareFolder(): JSONResponse {
		$this->config->deleteUserValue($this->userId, Application::APP_ID, 'share_folder');
		return new JSONResponse();
	}
}