diff options
| author | Corey Frang <gnarf@gnarf.net> | 2011-08-03 22:16:34 -0500 |
|---|---|---|
| committer | Corey Frang <gnarf@gnarf.net> | 2011-08-03 22:16:34 -0500 |
| commit | 065aef537b7533046907fcffc6896949e44679eb (patch) | |
| tree | cf4ea39e51df95073bef7c577c869016b1abc810 | |
| parent | 6fb68568bea4fcaf0caff77363819b3d7c732cd4 (diff) | |
| download | jquery-ui-065aef537b7533046907fcffc6896949e44679eb.tar.gz jquery-ui-065aef537b7533046907fcffc6896949e44679eb.zip | |
Button: Adding quotes to the attribute selector for labels - Fixes #7534 - Button label selector omits quotes / fails for ids with ":"
| -rw-r--r-- | tests/unit/button/button_tickets.js | 6 | ||||
| -rw-r--r-- | ui/jquery.ui.button.js | 2 |
2 files changed, 7 insertions, 1 deletions
diff --git a/tests/unit/button/button_tickets.js b/tests/unit/button/button_tickets.js index 2912b06a3..624d16716 100644 --- a/tests/unit/button/button_tickets.js +++ b/tests/unit/button/button_tickets.js @@ -50,4 +50,10 @@ test( "#7092 - button creation that requires a matching label does not find labe ok( group.find( "label" ).is( ".ui-button" ) ); }); +test( "#7534 - Button label selector works for ids with \":\"", function() { + var group = $( "<span><input type='checkbox' id='check:7534'><label for='check:7534'>Label</label></span>" ); + group.find( "input" ).button(); + ok( group.find( "label" ).is( ".ui-button" ), "Found an id with a :" ); +}); + })( jQuery ); diff --git a/ui/jquery.ui.button.js b/ui/jquery.ui.button.js index ad17ab0c1..89c52d007 100644 --- a/ui/jquery.ui.button.js +++ b/ui/jquery.ui.button.js @@ -229,7 +229,7 @@ $.widget( "ui.button", { // we don't search against the document in case the element // is disconnected from the DOM var ancestor = this.element.parents().last(), - labelSelector = "label[for=" + this.element.attr("id") + "]"; + labelSelector = "label[for='" + this.element.attr("id") + "']"; this.buttonElement = ancestor.find( labelSelector ); if ( !this.buttonElement.length ) { ancestor = ancestor.length ? ancestor.siblings() : this.element.siblings(); |