diff options
| author | Scott González <scott.gonzalez@gmail.com> | 2017-04-21 14:49:52 -0400 |
|---|---|---|
| committer | Scott González <scott.gonzalez@gmail.com> | 2017-04-24 12:41:29 -0400 |
| commit | b3c0a7f71d0b351755b97858ad47de4e9a373606 (patch) | |
| tree | aa69ee7e6c9388007ee398978adf1f0bc2e175cd | |
| parent | ef2e9bab92ae898311baa295590cd487d9071319 (diff) | |
| download | jquery-ui-b3c0a7f71d0b351755b97858ad47de4e9a373606.tar.gz jquery-ui-b3c0a7f71d0b351755b97858ad47de4e9a373606.zip | |
Widget: Handle `Object.create(null)` for options objects
Fixes #15179
Closes gh-1809
| -rw-r--r-- | tests/unit/widget/extend.js | 7 | ||||
| -rw-r--r-- | ui/widget.js | 3 |
2 files changed, 8 insertions, 2 deletions
diff --git a/tests/unit/widget/extend.js b/tests/unit/widget/extend.js index 36575200b..b27d925f0 100644 --- a/tests/unit/widget/extend.js +++ b/tests/unit/widget/extend.js @@ -5,7 +5,7 @@ define( [ ], function( QUnit, $ ) { QUnit.test( "$.widget.extend()", function( assert ) { - assert.expect( 27 ); + assert.expect( 28 ); var ret, empty, optionsWithLength, optionsWithDate, myKlass, customObject, optionsWithCustomObject, nullUndef, target, recursive, obj, input, output, @@ -108,6 +108,11 @@ QUnit.test( "$.widget.extend()", function( assert ) { assert.deepEqual( input, output, "don't clone arrays" ); input.key[ 0 ] = 10; assert.deepEqual( input, output, "don't clone arrays" ); + + input = Object.create( null ); + input.foo = "f"; + output = $.widget.extend( {}, input ); + assert.deepEqual( input, output, "Object with no prototype" ); } ); } ); diff --git a/ui/widget.js b/ui/widget.js index f87675712..011396811 100644 --- a/ui/widget.js +++ b/ui/widget.js @@ -26,6 +26,7 @@ }( function( $ ) { var widgetUuid = 0; +var widgetHasOwnProperty = Array.prototype.hasOwnProperty; var widgetSlice = Array.prototype.slice; $.cleanData = ( function( orig ) { @@ -183,7 +184,7 @@ $.widget.extend = function( target ) { for ( ; inputIndex < inputLength; inputIndex++ ) { for ( key in input[ inputIndex ] ) { value = input[ inputIndex ][ key ]; - if ( input[ inputIndex ].hasOwnProperty( key ) && value !== undefined ) { + if ( widgetHasOwnProperty.call( input[ inputIndex ], key ) && value !== undefined ) { // Clone objects if ( $.isPlainObject( value ) ) { |