aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorScott González <scott.gonzalez@gmail.com>2012-05-21 12:47:15 -0400
committerScott González <scott.gonzalez@gmail.com>2012-05-21 12:47:15 -0400
commite6f21410ff4e2e88ed5f44c872451e8030898178 (patch)
treefaf2eafd3157e97dfec041ace150da2cb68d0c2f
parent9ac52deaa271d3162e3d24724faf03f0b92ba3df (diff)
downloadjquery-ui-e6f21410ff4e2e88ed5f44c872451e8030898178.tar.gz
jquery-ui-e6f21410ff4e2e88ed5f44c872451e8030898178.zip
Don't use :checkbox selector.
-rw-r--r--tests/unit/button/button_tickets.js10
-rw-r--r--ui/jquery.ui.button.js4
2 files changed, 7 insertions, 7 deletions
diff --git a/tests/unit/button/button_tickets.js b/tests/unit/button/button_tickets.js
index 43bfdb833..fe0d82fd6 100644
--- a/tests/unit/button/button_tickets.js
+++ b/tests/unit/button/button_tickets.js
@@ -30,23 +30,23 @@ test( "#6711 Checkbox/Radiobutton do not Show Focused State when using Keyboard
test( "#7092 - button creation that requires a matching label does not find label in all cases", function() {
var group = $( "<span><label for='t7092a'></label><input type='checkbox' id='t7092a'></span>" );
- group.find( "input:checkbox" ).button();
+ group.find( "input[type=checkbox]" ).button();
ok( group.find( "label" ).is( ".ui-button" ) );
group = $( "<input type='checkbox' id='t7092b'><label for='t7092b'></label>" );
- group.filter( "input:checkbox" ).button();
+ group.filter( "input[type=checkbox]" ).button();
ok( group.filter( "label" ).is( ".ui-button" ) );
group = $( "<span><input type='checkbox' id='t7092c'></span><label for='t7092c'></label>" );
- group.find( "input:checkbox" ).button();
+ group.find( "input[type=checkbox]" ).button();
ok( group.filter( "label" ).is( ".ui-button" ) );
group = $( "<span><input type='checkbox' id='t7092d'></span><span><label for='t7092d'></label></span>" );
- group.find( "input:checkbox" ).button();
+ group.find( "input[type=checkbox]" ).button();
ok( group.find( "label" ).is( ".ui-button" ) );
group = $( "<input type='checkbox' id='t7092e'><span><label for='t7092e'></label></span>" );
- group.filter( "input:checkbox" ).button();
+ group.filter( "input[type=checkbox]" ).button();
ok( group.find( "label" ).is( ".ui-button" ) );
});
diff --git a/ui/jquery.ui.button.js b/ui/jquery.ui.button.js
index bd0af9408..44dbc68db 100644
--- a/ui/jquery.ui.button.js
+++ b/ui/jquery.ui.button.js
@@ -214,7 +214,7 @@ $.widget( "ui.button", {
_determineButtonType: function() {
var ancestor, labelSelector, checked;
- if ( this.element.is(":checkbox") ) {
+ if ( this.element.is("[type=checkbox]") ) {
this.type = "checkbox";
} else if ( this.element.is("[type=radio]") ) {
this.type = "radio";
@@ -358,7 +358,7 @@ $.ui.button.version = "@VERSION";
$.widget( "ui.buttonset", {
options: {
- items: ":button, :submit, :reset, :checkbox, [type=radio], a, :data(button)"
+ items: ":button, :submit, :reset, [type=checkbox], [type=radio], a, :data(button)"
},
_create: function() {