diff options
| author | Mike Sherov <mike.sherov@gmail.com> | 2014-08-24 21:10:08 -0400 |
|---|---|---|
| committer | Mike Sherov <mike.sherov@gmail.com> | 2014-08-25 08:26:57 -0400 |
| commit | e8c99b9abf7ca9368668ee5886e469d31ea33c09 (patch) | |
| tree | 29e4ce9405b2fee9976bd5e9529caf69d11c8140 | |
| parent | 27ed20715f4b3e256f5279825ac551bbfcdfbe81 (diff) | |
| download | jquery-ui-e8c99b9abf7ca9368668ee5886e469d31ea33c09.tar.gz jquery-ui-e8c99b9abf7ca9368668ee5886e469d31ea33c09.zip | |
Draggable: Ensure sortable revert still works after draggable is removed
Fixes #9481
| -rw-r--r-- | ui/draggable.js | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/ui/draggable.js b/ui/draggable.js index ba8eca42b..87176150e 100644 --- a/ui/draggable.js +++ b/ui/draggable.js @@ -713,8 +713,7 @@ $.ui.plugin.add("draggable", "connectToSortable", { var sortable = $( this ).sortable( "instance" ); if (sortable && !sortable.options.disabled) { inst.sortables.push({ - instance: sortable, - shouldRevert: sortable.options.revert + instance: sortable }); sortable.refreshPositions(); // Call the sortable's refreshPositions at drag start to refresh the containerCache since the sortable container cache is used in drag and needs to be up to date (this will ensure it's initialised as well as being kept in step with any changes that might have happened on the page). sortable._trigger("activate", event, uiSortable); @@ -740,10 +739,6 @@ $.ui.plugin.add("draggable", "connectToSortable", { inst.cancelHelperRemoval = true; this.instance.cancelHelperRemoval = false; - //The sortable revert is supported, and we have to set a temporary dropped variable on the draggable to support revert: "valid/invalid" - if (this.shouldRevert) { - this.instance.options.revert = this.shouldRevert; - } // Use _storedCSS To restore properties in the sortable, // as this also handles revert (#9675) since the draggable // may have modified them in unexpected ways (#8809) @@ -859,12 +854,18 @@ $.ui.plugin.add("draggable", "connectToSortable", { sortable.isOver = 0; sortable.cancelHelperRemoval = true; - // Prevent reverting on this forced stop + // Calling sortable's mouseStop would trigger a revert, + // so revert must be temporarily false until after mouseStop is called. + sortable.options._revert = sortable.options.revert; sortable.options.revert = false; sortable._trigger( "out", event, sortable._uiHash( sortable ) ); sortable._mouseStop( event, true ); + + // restore sortable behaviors that were modfied + // when the draggable entered the sortable area (#9481) + sortable.options.revert = sortable.options._revert; sortable.options.helper = sortable.options._helper; if ( sortable.placeholder ) { |