diff options
author | Scott González <scott.gonzalez@gmail.com> | 2012-05-16 09:27:26 -0400 |
---|---|---|
committer | Scott González <scott.gonzalez@gmail.com> | 2012-05-16 09:27:26 -0400 |
commit | 5912d36374499e15d8d184df5ca122a4c4a4990f (patch) | |
tree | badfd8af85c9d54a58375bed31c29db015b7aff8 /README.md | |
parent | 00086a8ab38ee55deeef78fa787ecfe9314185a5 (diff) | |
download | jquery-ui-5912d36374499e15d8d184df5ca122a4c4a4990f.tar.gz jquery-ui-5912d36374499e15d8d184df5ca122a4c4a4990f.zip |
Readme: Added more details about landing pull requests.
Diffstat (limited to 'README.md')
-rw-r--r-- | README.md | 7 |
1 files changed, 7 insertions, 0 deletions
@@ -11,6 +11,7 @@ To discuss development with team members and the community, visit the [Developin For contributors --- + If you want to help and provide a patch for a bugfix or new feature, please take a few minutes and look at [our Getting Involved guide](http://wiki.jqueryui.com/w/page/35263114/Getting-Involved). In particular check out the [Coding standards](http://wiki.jqueryui.com/w/page/12137737/Coding-standards) @@ -53,9 +54,15 @@ Run grunt. For committers --- + When looking at pull requests, first check for [proper commit messages](http://wiki.jqueryui.com/w/page/12137724/Bug-Fixing-Guide). Do not merge pull requests directly through GitHub's interface. +Most pull requests are a single commit; cherry-picking will avoid creating a merge commit. +It's also common for contributors to make minor fixes in an additional one or two commits. +These should be squashed before landing in master. + +**Make sure the author has a valid name and email address associated with the commit.** Fetch the remote first: |