diff options
| author | Michał Gołębiowski-Owczarek <m.goleb@gmail.com> | 2020-05-16 09:16:24 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-05-16 09:16:24 +0200 |
| commit | e7a10c70ae75c741992afdda60a433be205fd85e (patch) | |
| tree | 7c9f0d717f944107930608316ed346fbdf5f12c5 /tests/unit/autocomplete | |
| parent | f4ef03e57edd7e51cb134e902679c7bddc3daaee (diff) | |
| download | jquery-ui-e7a10c70ae75c741992afdda60a433be205fd85e.tar.gz jquery-ui-e7a10c70ae75c741992afdda60a433be205fd85e.zip | |
Tests: Ensure no timers are running at the end of each test (#1920)
This helps fix issues that make tooltip tests sometimes fail when run against
jQuery 3.2 or newer due to timing differences.
Details:
* Add the `moduleAfterEach` function ensuring no timers are running.
* Attach this function via `common.testWidget`.
* Attach this function to most test suites.
* Add a tooltip test helper cleaning up leftover timers.
* Rename legacy `setup`/`teardown` hooks to `beforeEach`/`afterEach`.
Closes gh-1920
Diffstat (limited to 'tests/unit/autocomplete')
| -rw-r--r-- | tests/unit/autocomplete/core.js | 5 | ||||
| -rw-r--r-- | tests/unit/autocomplete/events.js | 5 | ||||
| -rw-r--r-- | tests/unit/autocomplete/methods.js | 5 | ||||
| -rw-r--r-- | tests/unit/autocomplete/options.js | 5 |
4 files changed, 12 insertions, 8 deletions
diff --git a/tests/unit/autocomplete/core.js b/tests/unit/autocomplete/core.js index 33ccb2f34..8768ec2af 100644 --- a/tests/unit/autocomplete/core.js +++ b/tests/unit/autocomplete/core.js @@ -1,10 +1,11 @@ define( [ "qunit", "jquery", + "lib/helper", "ui/widgets/autocomplete" -], function( QUnit, $ ) { +], function( QUnit, $, helper ) { -QUnit.module( "autocomplete: core" ); +QUnit.module( "autocomplete: core", { afterEach: helper.moduleAfterEach } ); QUnit.test( "markup structure", function( assert ) { assert.expect( 2 ); diff --git a/tests/unit/autocomplete/events.js b/tests/unit/autocomplete/events.js index f02d36dd7..801c2d935 100644 --- a/tests/unit/autocomplete/events.js +++ b/tests/unit/autocomplete/events.js @@ -1,10 +1,11 @@ define( [ "qunit", "jquery", + "lib/helper", "ui/widgets/autocomplete" -], function( QUnit, $ ) { +], function( QUnit, $, helper ) { -QUnit.module( "autocomplete: events" ); +QUnit.module( "autocomplete: events", { afterEach: helper.moduleAfterEach } ); var data = [ "Clojure", "COBOL", "ColdFusion", "Java", "JavaScript", "Scala", "Scheme" ]; diff --git a/tests/unit/autocomplete/methods.js b/tests/unit/autocomplete/methods.js index 7aa3058b3..597c9c2ad 100644 --- a/tests/unit/autocomplete/methods.js +++ b/tests/unit/autocomplete/methods.js @@ -1,10 +1,11 @@ define( [ "qunit", "jquery", + "lib/helper", "ui/widgets/autocomplete" -], function( QUnit, $ ) { +], function( QUnit, $, helper ) { -QUnit.module( "autocomplete: methods" ); +QUnit.module( "autocomplete: methods", { afterEach: helper.moduleAfterEach } ); QUnit.test( "destroy", function( assert ) { assert.expect( 1 ); diff --git a/tests/unit/autocomplete/options.js b/tests/unit/autocomplete/options.js index c3f445db1..c4de8d5d3 100644 --- a/tests/unit/autocomplete/options.js +++ b/tests/unit/autocomplete/options.js @@ -1,10 +1,11 @@ define( [ "qunit", "jquery", + "lib/helper", "ui/widgets/autocomplete" -], function( QUnit, $ ) { +], function( QUnit, $, helper ) { -QUnit.module( "autocomplete: options" ); +QUnit.module( "autocomplete: options", { afterEach: helper.moduleAfterEach } ); var data = [ "c++", "java", "php", "coldfusion", "javascript", "asp", "ruby", "python", "c", "scala", "groovy", "haskell", "perl" ]; |