Tests: Ensure no timers are running at the end of each test (#1920)

This helps fix issues that make tooltip tests sometimes fail when run against
jQuery 3.2 or newer due to timing differences.

Details:
* Add the `moduleAfterEach` function ensuring no timers are running.
* Attach this function via `common.testWidget`.
* Attach this function to most test suites.
* Add a tooltip test helper cleaning up leftover timers.
* Rename legacy `setup`/`teardown` hooks to `beforeEach`/`afterEach`.

Closes gh-1920

1 files changed, 5 insertions, 4 deletions

diff --git a/tests/unit/button/deprecated.js b/tests/unit/button/deprecated.js
index 86fca797e..6866f7371 100644
--- a/tests/unit/button/deprecated.js
+++ b/tests/unit/button/deprecated.js
@@ -1,10 +1,11 @@
 define( [
 	"qunit",
 	"jquery",
+	"lib/helper",
 	"ui/widgets/button"
-], function( QUnit, $ ) {
+], function( QUnit, $, helper ) {
 
-QUnit.module( "Button (deprecated): core" );
+QUnit.module( "Button (deprecated): core", { afterEach: helper.moduleAfterEach }  );
 
 QUnit.test( "Calling button on a checkbox input calls checkboxradio widget", function( assert ) {
 	var checkbox = $( "#checkbox01" );
@@ -27,7 +28,7 @@ QUnit.test( "Calling buttonset calls controlgroup", function( assert ) {
 	assert.ok( controlgroup.is( ":ui-controlgroup" ), "Calling buttonset creates controlgroup instance" );
 } );
 
-QUnit.module( "Button (deprecated): methods" );
+QUnit.module( "Button (deprecated): methods", { afterEach: helper.moduleAfterEach }  );
 
 QUnit.test( "destroy", function( assert ) {
 	assert.expect( 1 );
@@ -59,7 +60,7 @@ QUnit.test( "refresh: Ensure disabled state is preserved correctly.", function(
 
 } );
 
-QUnit.module( "button (deprecated): options" );
+QUnit.module( "button (deprecated): options", { afterEach: helper.moduleAfterEach }  );
 
 QUnit.test( "Setting items option on buttonset sets the button properties on the items option", function( assert ) {
 	assert.expect( 2 );