diff options
| author | Michał Gołębiowski-Owczarek <m.goleb@gmail.com> | 2020-05-16 09:16:24 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-05-16 09:16:24 +0200 |
| commit | e7a10c70ae75c741992afdda60a433be205fd85e (patch) | |
| tree | 7c9f0d717f944107930608316ed346fbdf5f12c5 /tests/unit/core | |
| parent | f4ef03e57edd7e51cb134e902679c7bddc3daaee (diff) | |
| download | jquery-ui-e7a10c70ae75c741992afdda60a433be205fd85e.tar.gz jquery-ui-e7a10c70ae75c741992afdda60a433be205fd85e.zip | |
Tests: Ensure no timers are running at the end of each test (#1920)
This helps fix issues that make tooltip tests sometimes fail when run against
jQuery 3.2 or newer due to timing differences.
Details:
* Add the `moduleAfterEach` function ensuring no timers are running.
* Attach this function via `common.testWidget`.
* Attach this function to most test suites.
* Add a tooltip test helper cleaning up leftover timers.
* Rename legacy `setup`/`teardown` hooks to `beforeEach`/`afterEach`.
Closes gh-1920
Diffstat (limited to 'tests/unit/core')
| -rw-r--r-- | tests/unit/core/core.js | 5 | ||||
| -rw-r--r-- | tests/unit/core/selector.js | 5 |
2 files changed, 6 insertions, 4 deletions
diff --git a/tests/unit/core/core.js b/tests/unit/core/core.js index acfc291ff..94c126123 100644 --- a/tests/unit/core/core.js +++ b/tests/unit/core/core.js @@ -2,12 +2,13 @@ define( [ "qunit", "jquery", "lib/common", + "lib/helper", "ui/form", "ui/labels", "ui/unique-id" -], function( QUnit, $, common ) { +], function( QUnit, $, common, helper ) { -QUnit.module( "core - jQuery extensions" ); +QUnit.module( "core - jQuery extensions", { afterEach: helper.moduleAfterEach } ); common.testJshint( "core" ); diff --git a/tests/unit/core/selector.js b/tests/unit/core/selector.js index 29b8b1296..f8b9f20c3 100644 --- a/tests/unit/core/selector.js +++ b/tests/unit/core/selector.js @@ -1,13 +1,14 @@ define( [ "qunit", "jquery", + "lib/helper", "ui/data", "ui/escape-selector", "ui/focusable", "ui/tabbable" -], function( QUnit, $ ) { +], function( QUnit, $, helper ) { -QUnit.module( "core - selectors" ); +QUnit.module( "core - selectors", { afterEach: helper.moduleAfterEach } ); QUnit.assert.isFocusable = function( selector, msg ) { this.push( $( selector ).is( ":focusable" ), null, null, |