diff options
| author | Michał Gołębiowski-Owczarek <m.goleb@gmail.com> | 2020-01-22 16:44:34 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-01-22 16:44:34 +0100 |
| commit | 0c860b0d92f9959f6747f8c02e9671eb2fc561aa (patch) | |
| tree | eec1af4f3a9eead707e2674593bda620b5f7c9cb /tests/unit/menu/helper.js | |
| parent | 3481f50bfcf02865857d390a1caa511003a40c13 (diff) | |
| download | jquery-ui-0c860b0d92f9959f6747f8c02e9671eb2fc561aa.tar.gz jquery-ui-0c860b0d92f9959f6747f8c02e9671eb2fc561aa.zip | |
All: Remove usage of jQuery positional selectors
jQuery positional selectors () have been deprecated in
[jQuery 3.4.0](https://blog.jquery.com/2019/04/10/jquery-3-4-0-released/)
and they'll be removed in jQuery 4.0.0. This PR removes their usage.
Most of the changes were possible without changing public API. However,
dropping `:even` usage required a change to the
[`header` option](https://api.jqueryui.com/accordion/#option-header)
of the accordion widget. I made it an optional function; this will need
to be documented.
The polyfill for `.even()` & `.odd()` is added for jQuery <3.5.0. There was
no usage of the :odd selector in the code but the `.odd()` method is also
polyfilled for completeness.
Closes gh-1904
Diffstat (limited to 'tests/unit/menu/helper.js')
| -rw-r--r-- | tests/unit/menu/helper.js | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tests/unit/menu/helper.js b/tests/unit/menu/helper.js index 1e4a21485..748dfe773 100644 --- a/tests/unit/menu/helper.js +++ b/tests/unit/menu/helper.js @@ -27,7 +27,8 @@ return $.extend( helper, { click: function( menu, item ) { lastItem = item; - menu.children( ":eq(" + item + ")" ) + menu.children() + .eq( item ) .children( ".ui-menu-item-wrapper" ) .trigger( "click" ); } |