diff options
| author | Michał Gołębiowski-Owczarek <m.goleb@gmail.com> | 2020-05-16 09:16:24 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-05-16 09:16:24 +0200 |
| commit | e7a10c70ae75c741992afdda60a433be205fd85e (patch) | |
| tree | 7c9f0d717f944107930608316ed346fbdf5f12c5 /tests/unit/menu | |
| parent | f4ef03e57edd7e51cb134e902679c7bddc3daaee (diff) | |
| download | jquery-ui-e7a10c70ae75c741992afdda60a433be205fd85e.tar.gz jquery-ui-e7a10c70ae75c741992afdda60a433be205fd85e.zip | |
Tests: Ensure no timers are running at the end of each test (#1920)
This helps fix issues that make tooltip tests sometimes fail when run against
jQuery 3.2 or newer due to timing differences.
Details:
* Add the `moduleAfterEach` function ensuring no timers are running.
* Attach this function via `common.testWidget`.
* Attach this function to most test suites.
* Add a tooltip test helper cleaning up leftover timers.
* Rename legacy `setup`/`teardown` hooks to `beforeEach`/`afterEach`.
Closes gh-1920
Diffstat (limited to 'tests/unit/menu')
| -rw-r--r-- | tests/unit/menu/core.js | 5 | ||||
| -rw-r--r-- | tests/unit/menu/events.js | 6 | ||||
| -rw-r--r-- | tests/unit/menu/methods.js | 6 | ||||
| -rw-r--r-- | tests/unit/menu/options.js | 6 |
4 files changed, 15 insertions, 8 deletions
diff --git a/tests/unit/menu/core.js b/tests/unit/menu/core.js index 8380d66bd..9e7bd1910 100644 --- a/tests/unit/menu/core.js +++ b/tests/unit/menu/core.js @@ -1,11 +1,12 @@ define( [ "qunit", "jquery", + "lib/helper", "./helper", "ui/widgets/menu" -], function( QUnit, $, testHelper ) { +], function( QUnit, $, helper, testHelper ) { -QUnit.module( "menu: core" ); +QUnit.module( "menu: core", { afterEach: helper.moduleAfterEach } ); QUnit.test( "markup structure", function( assert ) { assert.expect( 11 ); diff --git a/tests/unit/menu/events.js b/tests/unit/menu/events.js index 35eec7851..c50c184ec 100644 --- a/tests/unit/menu/events.js +++ b/tests/unit/menu/events.js @@ -1,9 +1,10 @@ define( [ "qunit", "jquery", + "lib/helper", "./helper", "ui/widgets/menu" -], function( QUnit, $, testHelper ) { +], function( QUnit, $, helper, testHelper ) { var log = testHelper.log, logOutput = testHelper.logOutput, @@ -12,7 +13,8 @@ var log = testHelper.log, QUnit.module( "menu: events", { beforeEach: function() { testHelper.clearLog(); - } + }, + afterEach: helper.moduleAfterEach } ); QUnit.test( "handle click on menu", function( assert ) { diff --git a/tests/unit/menu/methods.js b/tests/unit/menu/methods.js index e0e942dd6..a5e5a90e3 100644 --- a/tests/unit/menu/methods.js +++ b/tests/unit/menu/methods.js @@ -1,9 +1,10 @@ define( [ "qunit", "jquery", + "lib/helper", "./helper", "ui/widgets/menu" -], function( QUnit, $, testHelper ) { +], function( QUnit, $, helper, testHelper ) { var log = testHelper.log, logOutput = testHelper.logOutput, @@ -12,7 +13,8 @@ var log = testHelper.log, QUnit.module( "menu: methods", { beforeEach: function() { testHelper.clearLog(); - } + }, + afterEach: helper.moduleAfterEach } ); QUnit.test( "destroy", function( assert ) { diff --git a/tests/unit/menu/options.js b/tests/unit/menu/options.js index 8479b719c..525c6f016 100644 --- a/tests/unit/menu/options.js +++ b/tests/unit/menu/options.js @@ -1,9 +1,10 @@ define( [ "qunit", "jquery", + "lib/helper", "./helper", "ui/widgets/menu" -], function( QUnit, $, testHelper ) { +], function( QUnit, $, helper, testHelper ) { var log = testHelper.log, logOutput = testHelper.logOutput, @@ -12,7 +13,8 @@ var log = testHelper.log, QUnit.module( "menu: options", { beforeEach: function() { testHelper.clearLog(); - } + }, + afterEach: helper.moduleAfterEach } ); QUnit.test( "{ disabled: true }", function( assert ) { |