diff options
| author | Michał Gołębiowski-Owczarek <m.goleb@gmail.com> | 2020-05-16 09:16:24 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-05-16 09:16:24 +0200 |
| commit | e7a10c70ae75c741992afdda60a433be205fd85e (patch) | |
| tree | 7c9f0d717f944107930608316ed346fbdf5f12c5 /tests/unit/selectable | |
| parent | f4ef03e57edd7e51cb134e902679c7bddc3daaee (diff) | |
| download | jquery-ui-e7a10c70ae75c741992afdda60a433be205fd85e.tar.gz jquery-ui-e7a10c70ae75c741992afdda60a433be205fd85e.zip | |
Tests: Ensure no timers are running at the end of each test (#1920)
This helps fix issues that make tooltip tests sometimes fail when run against
jQuery 3.2 or newer due to timing differences.
Details:
* Add the `moduleAfterEach` function ensuring no timers are running.
* Attach this function via `common.testWidget`.
* Attach this function to most test suites.
* Add a tooltip test helper cleaning up leftover timers.
* Rename legacy `setup`/`teardown` hooks to `beforeEach`/`afterEach`.
Closes gh-1920
Diffstat (limited to 'tests/unit/selectable')
| -rw-r--r-- | tests/unit/selectable/events.js | 2 | ||||
| -rw-r--r-- | tests/unit/selectable/methods.js | 5 | ||||
| -rw-r--r-- | tests/unit/selectable/options.js | 5 |
3 files changed, 7 insertions, 5 deletions
diff --git a/tests/unit/selectable/events.js b/tests/unit/selectable/events.js index 7f8e2baee..1ef45264e 100644 --- a/tests/unit/selectable/events.js +++ b/tests/unit/selectable/events.js @@ -5,7 +5,7 @@ define( [ "ui/widgets/selectable" ], function( QUnit, $, testHelpers ) { -QUnit.module( "selectable: events" ); +QUnit.module( "selectable: events", { afterEach: testHelpers.moduleAfterEach } ); QUnit.test( "start", function( assert ) { assert.expect( 2 ); diff --git a/tests/unit/selectable/methods.js b/tests/unit/selectable/methods.js index c56c228bc..d0dc23e69 100644 --- a/tests/unit/selectable/methods.js +++ b/tests/unit/selectable/methods.js @@ -1,10 +1,11 @@ define( [ "qunit", "jquery", + "lib/helper", "ui/widgets/selectable" -], function( QUnit, $ ) { +], function( QUnit, $, helper ) { -QUnit.module( "selectable: methods" ); +QUnit.module( "selectable: methods", { afterEach: helper.moduleAfterEach } ); QUnit.test( "init", function( assert ) { assert.expect( 5 ); diff --git a/tests/unit/selectable/options.js b/tests/unit/selectable/options.js index 58d4b6eb5..02c0d2b2a 100644 --- a/tests/unit/selectable/options.js +++ b/tests/unit/selectable/options.js @@ -1,10 +1,11 @@ define( [ "qunit", "jquery", + "lib/helper", "ui/widgets/selectable" -], function( QUnit, $ ) { +], function( QUnit, $, helper ) { -QUnit.module( "selectable: options" ); +QUnit.module( "selectable: options", { afterEach: helper.moduleAfterEach } ); QUnit.test( "autoRefresh", function( assert ) { assert.expect( 3 ); |