diff options
| author | Mike Sherov <mike.sherov@gmail.com> | 2012-10-23 09:36:42 -0500 |
|---|---|---|
| committer | Corey Frang <gnarf@gnarf.net> | 2012-10-23 09:37:46 -0500 |
| commit | e1230997aa14dae6f35326c8ba20bfe2428507c2 (patch) | |
| tree | f00984f5fbbf12f175c0994c497513a2d8e8ee26 /tests/unit/sortable | |
| parent | 7af1ec727bcca8367e804cea77b9dd238b1c0d69 (diff) | |
| download | jquery-ui-e1230997aa14dae6f35326c8ba20bfe2428507c2.tar.gz jquery-ui-e1230997aa14dae6f35326c8ba20bfe2428507c2.zip | |
Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
Squashed commit of the following:
commit 7f19f92c646f180bc067bb24123175251a64a9d6
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Tue Oct 23 10:34:28 2012 -0400
put back in fake args for signatures that we want to keep
commit 257505a9e69da0c53e3a989dab87a13112045a29
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Tue Oct 23 08:10:20 2012 -0400
changes per @scott_gonzalez
commit 12725480cb58e70865e5aa6e735009b6b035c8f3
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Mon Oct 22 22:54:05 2012 -0400
clean up unused vars in ui directory
commit 563595e7aee5d4a5c096b2d1de655abdf920aacd
Author: Mike Sherov <mike.sherov@gmail.com>
Date: Mon Oct 22 22:37:42 2012 -0400
clean up unused vars in grunt and tests
Diffstat (limited to 'tests/unit/sortable')
| -rw-r--r-- | tests/unit/sortable/sortable_core.js | 4 | ||||
| -rw-r--r-- | tests/unit/sortable/sortable_options.js | 4 | ||||
| -rw-r--r-- | tests/unit/sortable/sortable_tickets.js | 6 |
3 files changed, 11 insertions, 3 deletions
diff --git a/tests/unit/sortable/sortable_core.js b/tests/unit/sortable/sortable_core.js index ff1859874..540e06f0f 100644 --- a/tests/unit/sortable/sortable_core.js +++ b/tests/unit/sortable/sortable_core.js @@ -6,4 +6,8 @@ module("sortable: core"); +// this is here to make JSHint pass "unused", and we don't want to +// remove the parameter for when we finally implement +$.noop(); + })(jQuery); diff --git a/tests/unit/sortable/sortable_options.js b/tests/unit/sortable/sortable_options.js index a043e68fe..d5d7b3de1 100644 --- a/tests/unit/sortable/sortable_options.js +++ b/tests/unit/sortable/sortable_options.js @@ -5,6 +5,10 @@ module("sortable: options"); +// this is here to make JSHint pass "unused", and we don't want to +// remove the parameter for when we finally implement +$.noop(); + test("{ appendTo: 'parent' }, default", function() { ok(false, "missing test - untested code is broken code."); }); diff --git a/tests/unit/sortable/sortable_tickets.js b/tests/unit/sortable/sortable_tickets.js index 22ad61baf..14bb705ea 100644 --- a/tests/unit/sortable/sortable_tickets.js +++ b/tests/unit/sortable/sortable_tickets.js @@ -44,13 +44,13 @@ test('#4752: link event firing on sortable with connect list', function () { $('#main ul').sortable({ connectWith: '#main ul', - change: function (e, ui) { + change: function () { fired.change = true; }, - receive: function (e, ui) { + receive: function () { fired.receive = true; }, - remove: function (e, ui) { + remove: function () { fired.remove = true; } }); |