All: Migrate away from deprecated/removed Core APIs

Summary of the changes:

* Build: Add jQuery 3.2.0-3.4.1 to versions UI can be tested against
* Build: Load jQuery & Migrate via HTTPS
* Build: Add package-lock.json to .gitignore
* Build: Update jQuery Migrate from 3.0.0 to 3.1.0
* Build: Allow to run tests against jQuery 3.x-git
* Build: Fix formatting according to JSCS rules
* Build: Disable JSCS for the inlined jQuery Color
* All: Switch from $.isArray to Array.isArray (jQuery.isArray will be
  removed in jQuery 4.0)
* All: Switch from `$.isFunction( x )` to `typeof x === "function"`
  (jQuery.isFunction will be removed in jQuery 4.0)
* All: Inline jQuery.isWindow as it'll be removed in jQuery 4.0
* Effects: Fix a timing issue in a variable declaration. Previously,
  a jQuery object was created, chained & assigned to a variable that
  was then accessed in a callback used inside of this chained
  definition. Due to a timing difference in when the callback fired for
  the first time in latest jQuery master, it was being called before
  the variable was defined.
* Tests: Make dialog & draggable unit tests less strict (newest jQuery
  returns fractional results in some cases, making comparisons fail when
  there's a tiny difference)
* All: Migrate from $.trim to bare String.prototype.trim (jQuery.trim
  will be deprecated in jQuery 3.5)

Closes gh-1901

1 files changed, 5 insertions, 5 deletions

diff --git a/tests/unit/widget/core.js b/tests/unit/widget/core.js
index d6bb3efb8..283b55416 100644
--- a/tests/unit/widget/core.js
+++ b/tests/unit/widget/core.js
@@ -29,7 +29,7 @@ QUnit.test( "widget creation", function( assert ) {
 		};
 
 	$.widget( "ui.testWidget", myPrototype );
-	assert.ok( $.isFunction( $.ui.testWidget ), "constructor was created" );
+	assert.ok( typeof $.ui.testWidget === "function", "constructor was created" );
 	assert.equal( typeof $.ui.testWidget.prototype, "object", "prototype was created" );
 	method = "_create";
 	$.ui.testWidget.prototype._create();
@@ -947,7 +947,7 @@ QUnit.test( "_on() with delegate", function( assert ) {
 			this.element = {
 				on: function( event, handler ) {
 					assert.equal( event, "click.testWidget" + uuid );
-					assert.ok( $.isFunction( handler ) );
+					assert.ok( typeof handler === "function" );
 				},
 				trigger: $.noop
 			};
@@ -956,7 +956,7 @@ QUnit.test( "_on() with delegate", function( assert ) {
 					on: function( event, selector, handler ) {
 						assert.equal( selector, "a" );
 						assert.equal( event, "click.testWidget" + uuid );
-						assert.ok( $.isFunction( handler ) );
+						assert.ok( typeof handler === "function" );
 					}
 				};
 			};
@@ -969,7 +969,7 @@ QUnit.test( "_on() with delegate", function( assert ) {
 					on: function( event, selector, handler ) {
 						assert.equal( selector, "form fieldset > input" );
 						assert.equal( event, "change.testWidget" + uuid );
-						assert.ok( $.isFunction( handler ) );
+						assert.ok( typeof handler === "function" );
 					}
 				};
 			};
@@ -1608,7 +1608,7 @@ QUnit.test( "$.widget.bridge()", function( assert ) {
 
 	$.widget.bridge( "testWidget", TestWidget );
 
-	assert.ok( $.isFunction( $.fn.testWidget ), "jQuery plugin was created" );
+	assert.ok( typeof $.fn.testWidget === "function", "jQuery plugin was created" );
 
 	assert.strictEqual( elem.testWidget( { foo: "bar" } ), elem, "plugin returns original jQuery object" );
 	instance = elem.data( "testWidget" );