diff options
| author | Michał Gołębiowski-Owczarek <m.goleb@gmail.com> | 2020-01-22 16:44:34 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-01-22 16:44:34 +0100 |
| commit | 0c860b0d92f9959f6747f8c02e9671eb2fc561aa (patch) | |
| tree | eec1af4f3a9eead707e2674593bda620b5f7c9cb /tests/visual | |
| parent | 3481f50bfcf02865857d390a1caa511003a40c13 (diff) | |
| download | jquery-ui-0c860b0d92f9959f6747f8c02e9671eb2fc561aa.tar.gz jquery-ui-0c860b0d92f9959f6747f8c02e9671eb2fc561aa.zip | |
All: Remove usage of jQuery positional selectors
jQuery positional selectors () have been deprecated in
[jQuery 3.4.0](https://blog.jquery.com/2019/04/10/jquery-3-4-0-released/)
and they'll be removed in jQuery 4.0.0. This PR removes their usage.
Most of the changes were possible without changing public API. However,
dropping `:even` usage required a change to the
[`header` option](https://api.jqueryui.com/accordion/#option-header)
of the accordion widget. I made it an optional function; this will need
to be documented.
The polyfill for `.even()` & `.odd()` is added for jQuery <3.5.0. There was
no usage of the :odd selector in the code but the `.odd()` method is also
polyfilled for completeness.
Closes gh-1904
Diffstat (limited to 'tests/visual')
| -rw-r--r-- | tests/visual/compound/draggable_resizable.html | 2 | ||||
| -rw-r--r-- | tests/visual/effects/effects.js | 2 | ||||
| -rw-r--r-- | tests/visual/selectmenu/selectmenu.html | 8 |
3 files changed, 6 insertions, 6 deletions
diff --git a/tests/visual/compound/draggable_resizable.html b/tests/visual/compound/draggable_resizable.html index 539091b7f..e2822ca19 100644 --- a/tests/visual/compound/draggable_resizable.html +++ b/tests/visual/compound/draggable_resizable.html @@ -27,7 +27,7 @@ minHeight: 13, handles: "s" }); - $( ".draggable:last" ).addClass( "absolute" ); + $( ".draggable" ).last().addClass( "absolute" ); </script> </head> <body> diff --git a/tests/visual/effects/effects.js b/tests/visual/effects/effects.js index 6d36a55ea..ebe3347f2 100644 --- a/tests/visual/effects/effects.js +++ b/tests/visual/effects/effects.js @@ -86,7 +86,7 @@ effect( "#slideRight", "slide", { direction: "right" } ); $( "#transfer" ).on( "click", function() { $( this ) .addClass( "current" ) - .effect( "transfer", { to: "div:eq(0)" }, 1000, function() { + .effect( "transfer", { to: $( "div" ).eq( 0 ) }, 1000, function() { $( this ).removeClass( "current" ); } ); } ); diff --git a/tests/visual/selectmenu/selectmenu.html b/tests/visual/selectmenu/selectmenu.html index 693885d25..0dbfc3882 100644 --- a/tests/visual/selectmenu/selectmenu.html +++ b/tests/visual/selectmenu/selectmenu.html @@ -89,10 +89,10 @@ $("#disable_option").on("click", function() { if (disable_option) { disable_option = false; - disabled4.find("option:eq(0)").attr("disabled", "disabled"); + disabled4.find( "option" ).eq( 0 ).attr("disabled", "disabled"); } else { disable_option = true; - disabled4.find("option:eq(0)").removeAttr("disabled"); + disabled4.find( "option" ).eq( 0 ).removeAttr("disabled"); } disabled4.selectmenu("refresh"); return false; @@ -101,10 +101,10 @@ $("#disable_optgroup").on("click", function() { if (disable_optgroup) { disable_optgroup = false; - disabled4.find("optgroup:eq(0)").attr("disabled", "disabled"); + disabled4.find( "optgroup" ).eq( 0 ).attr("disabled", "disabled"); } else { disable_optgroup = true; - disabled4.find("optgroup:eq(0)").removeAttr("disabled"); + disabled4.find( "optgroup" ).eq( 0 ).removeAttr("disabled"); } disabled4.selectmenu("refresh"); return false; |