Effects: Rewrite

1. Introduces a set of helper methods to easily create and define new effects.
2. Uses clip animations and placeholders instead of wrappers for clip effects.
3. Ensures all animations are detectable as animated

Fixes #10599
Fixes #9477
Fixes #9257
Fixes #9066
Fixes #8867
Fixes #8671
Fixes #8505
Fixes #7885
Fixes #7041

Closes gh-1017

5 files changed, 6 insertions, 2 deletions

diff --git a/tests/visual/effects/all.html b/tests/visual/effects/all.html
index 9fb4cf9c4..c1bdd9fa3 100644
--- a/tests/visual/effects/all.html
+++ b/tests/visual/effects/all.html
@@ -14,8 +14,10 @@
 	<script src="../../../ui/effect-fade.js"></script>
 	<script src="../../../ui/effect-fold.js"></script>
 	<script src="../../../ui/effect-highlight.js"></script>
+	<script src="../../../ui/effect-puff.js"></script>
 	<script src="../../../ui/effect-pulsate.js"></script>
 	<script src="../../../ui/effect-scale.js"></script>
+	<script src="../../../ui/effect-size.js"></script>
 	<script src="../../../ui/effect-shake.js"></script>
 	<script src="../../../ui/effect-slide.js"></script>
 	<script src="../../../ui/effect-transfer.js"></script>
diff --git a/tests/visual/effects/clip.html b/tests/visual/effects/clip.html
index 49efa6d8b..f56f54189 100644
--- a/tests/visual/effects/clip.html
+++ b/tests/visual/effects/clip.html
@@ -70,6 +70,7 @@
 <p>EXPECTED: Clicking "Toggle" or "Effect Toggle" a second time reverses the animation, first showing all elements at their original dimensions, and restoring them to their original state.</p>
 <p>EXPECTED: Clicking "Effect Default" should always perform a "hide" animation.</p>
 <p>EXPECTED: Clicking any of the buttons in quick succession should queue the relevant animations.</p>
+<p>EXPECTED CANTFIX: In IE8, the clip animation jumps due to a bug that causes .css('clip') to return undefined unless the clip property is an inline style.</p>
 
 <div class="container">
 	<button class="toggle">Toggle</button>
@@ -80,7 +81,7 @@
 	<p>Jerky corned beef short loin fatback jowl tail. Rump spare ribs shoulder pork belly. Sausage cow ground round bacon. Bresaola kielbasa pastrami brisket ham hock. Andouille kielbasa ham, pork beef tenderloin ground round beef ribs flank turkey pancetta tri-tip.</p>
 	<div class="column">
 		<p>Shankle filet mignon ribeye chicken, bacon jowl drumstick frankfurter swine short loin capicola leberkas tenderloin pig. Shankle bacon shank pork loin, shoulder ham drumstick biltong. Shankle ham pastrami ball tip turkey leberkas pork loin ground round. Chicken strip steak venison shoulder biltong ham. Bacon pork loin tenderloin kielbasa, prosciutto sausage leberkas jowl ribeye turducken. Flank short loin venison tenderloin spare ribs boudin, tongue pork chop shank sirloin. Ground round ham pork belly, corned beef jowl strip steak short ribs prosciutto pig bresaola spare ribs.</p>
-		<img class="target" style="margin: 10px 20px 30px 40px;" src="../../images/jquery_521x191.png" alt="jQuery Logo">
+		<img class="target margin" src="../../images/jquery_521x191.png" alt="jQuery Logo">
 		<p>Pork loin biltong ball tip tail jerky beef ribs prosciutto short loin turducken. Turkey chicken jowl pork loin shank tri-tip swine brisket. Doner prosciutto leberkas venison ground round, short loin capicola hamburger pork bacon. Spare ribs beef pork tenderloin rump shoulder pork belly turducken cow beef ribs pastrami tail flank. Spare ribs tri-tip shank, pork beef ribs ribeye chicken bacon boudin shoulder venison. Sirloin beef ribs boudin, andouille doner tail ball tip biltong prosciutto chicken beef turkey tongue hamburger tri-tip.</p>
 	</div>
 	<p>Doner salami jowl beef ribs. Pork chop beef short loin pork, kielbasa tail andouille salami sausage meatball short ribs t-bone tri-tip ham. Meatball short ribs prosciutto flank chicken fatback frankfurter brisket turducken. Corned beef hamburger swine short ribs pancetta. Jerky bresaola pork chuck spare ribs pastrami shoulder flank chicken leberkas beef.</p>
diff --git a/tests/visual/effects/effects.js b/tests/visual/effects/effects.js
index 624e0b128..f0963a99d 100644
--- a/tests/visual/effects/effects.js
+++ b/tests/visual/effects/effects.js
@@ -57,7 +57,7 @@ effect( "#highlight", "highlight", {} );
 
 effect( "#pulsate", "pulsate", { times: 2 } );
 
-effect( "#puff", "puff", { times: 2 } );
+effect( "#puff", "puff", {} );
 effect( "#scale", "scale", {} );
 effect( "#size", "size", {} );
 $( "#sizeToggle" ).click(function() {
diff --git a/tests/visual/effects/image.png b/tests/visual/effects/image.png
new file mode 100644
index 000000000..4ec90439a
--- /dev/null
+++ b/tests/visual/effects/image.png
diff --git a/tests/visual/index.html b/tests/visual/index.html
index f7d516f20..0c9b14da8 100644
--- a/tests/visual/index.html
+++ b/tests/visual/index.html
@@ -48,6 +48,7 @@
 		<h2>Effects</h2>
 		<ul>
 			<li><a href="effects/all.html">All</a></li>
+			<li><a href="effects/clip.html">Clip</a></li>
 			<li><a href="effects/scale.html">Scale</a></li>
 			<li><a href="effects/shake.html">Shake</a></li>
 		</ul>