diff options
author | Jörn Zaefferer <joern.zaefferer@gmail.com> | 2012-12-04 01:08:34 +0100 |
---|---|---|
committer | Jörn Zaefferer <joern.zaefferer@gmail.com> | 2012-12-04 01:08:34 +0100 |
commit | 1e8baf568365f8edc833439315f76e5efe1ba9b6 (patch) | |
tree | a59e9ff03f729d46b18530621797ad65c77f87b5 /tests | |
parent | b9068c1523f39da8a04c799eebc9adc8b83c7279 (diff) | |
download | jquery-ui-1e8baf568365f8edc833439315f76e5efe1ba9b6.tar.gz jquery-ui-1e8baf568365f8edc833439315f76e5efe1ba9b6.zip |
Dialog: Remove the instance-storing for the overlay, just create one whenever it is needed. Heavily simplifies the code, while the memorly leak should be hardly an issue anymore, since fixed positioning restricts the overlay size to the window dimensions. Fixes #6058 - Dialog overlays are not properly reused when multiple instances of a Dialog exist.
Diffstat (limited to 'tests')
-rw-r--r-- | tests/unit/dialog/dialog_tickets.js | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/tests/unit/dialog/dialog_tickets.js b/tests/unit/dialog/dialog_tickets.js index 655f1e445..389a243b3 100644 --- a/tests/unit/dialog/dialog_tickets.js +++ b/tests/unit/dialog/dialog_tickets.js @@ -107,17 +107,6 @@ test("#6137: dialog('open') causes form elements to reset on IE7", function() { d1.remove(); }); -test("#6645: Missing element not found check in overlay", function(){ - expect(2); - var d1 = $('<div title="dialog 1">Dialog 1</div>').dialog({modal: true}), - d2 = $('<div title="dialog 2">Dialog 2</div>').dialog({modal: true, close: function(){ d2.remove(); }}); - - equal($.ui.dialog.overlay.instances.length, 2, 'two overlays created'); - d2.dialog('close'); - equal($.ui.dialog.overlay.instances.length, 1, 'one overlay remains after closing the 2nd overlay'); - d1.add(d2).remove(); -}); - // TODO merge this with the main destroy test test("#4980: Destroy should place element back in original DOM position", function(){ expect( 2 ); |