aboutsummaryrefslogtreecommitdiffstats
path: root/ui/effect.js
diff options
context:
space:
mode:
authorMichał Gołębiowski-Owczarek <m.goleb@gmail.com>2021-09-03 14:42:30 +0200
committerGitHub <noreply@github.com>2021-09-03 14:42:30 +0200
commit2fd224d5cc3ac7ce37e3e60e4d28e19f89321dcd (patch)
tree44f8f77bd2d304a90fa87a2ae32fc6db7008bd3a /ui/effect.js
parenteda9f3b0d6676df900764da11124d688dec0b007 (diff)
downloadjquery-ui-2fd224d5cc3ac7ce37e3e60e4d28e19f89321dcd.tar.gz
jquery-ui-2fd224d5cc3ac7ce37e3e60e4d28e19f89321dcd.zip
Effect: Define the jQuery variable before jQuery Color gets imported
We need to create a local jQuery because jQuery Color relies on it and the global may not exist with AMD and a custom build (trac-10199). This worked in UI 1.12 but stopped in 1.13 as jQuery Color is now sourced as an AMD module and the variable started being defined after jQuery Color code. To restore the proper order, move the variable declaration to a separate small module loaded before jQuery Color. Closes gh-1973
Diffstat (limited to 'ui/effect.js')
-rw-r--r--ui/effect.js7
1 files changed, 2 insertions, 5 deletions
diff --git a/ui/effect.js b/ui/effect.js
index e2a072d96..37ce230c3 100644
--- a/ui/effect.js
+++ b/ui/effect.js
@@ -23,6 +23,7 @@
// AMD. Register as an anonymous module.
define( [
"jquery",
+ "./jquery-var-for-color",
"./vendor/jquery-color/jquery.color",
"./version"
], factory );
@@ -36,11 +37,7 @@
var dataSpace = "ui-effects-",
dataSpaceStyle = "ui-effects-style",
- dataSpaceAnimated = "ui-effects-animated",
-
- // Create a local jQuery because jQuery Color relies on it and the
- // global may not exist with AMD and a custom build (#10199)
- jQuery = $;
+ dataSpaceAnimated = "ui-effects-animated";
$.effects = {
effect: {}