effects.*: More Style Guidance

1 files changed, 10 insertions, 8 deletions

diff --git a/ui/jquery.effects.fade.js b/ui/jquery.effects.fade.js
index 9fa8a79c4..c6cb85cc2 100644
--- a/ui/jquery.effects.fade.js
+++ b/ui/jquery.effects.fade.js
@@ -12,18 +12,20 @@
  */
 (function( $, undefined ) {
 
-$.effects.fade = function(o) {
-	return this.queue(function() {
-		var elem = $(this),
-			mode = $.effects.setMode(elem, o.options.mode || 'hide');
+$.effects.fade = function( o ) {
+	return this.queue( function() {
+		var el = $( this ),
+			mode = $.effects.setMode( el, o.mode || 'hide' );
 
-		elem.animate({ opacity: mode }, {
+		el.animate({ 
+			opacity: mode 
+		}, {
 			queue: false,
 			duration: o.duration,
-			easing: o.options.easing,
+			easing: o.easing,
 			complete: function() {
-				(o.callback && o.callback.apply(this, arguments));
-				elem.dequeue();
+				jQuery.isFunction( o.complete ) && o.complete.apply( this, arguments );
+				el.dequeue();
 			}
 		});
 	});