aboutsummaryrefslogtreecommitdiffstats
path: root/ui/jquery.ui.dialog.js
diff options
context:
space:
mode:
authorScott González <scott.gonzalez@gmail.com>2010-08-27 16:49:07 -0400
committerScott González <scott.gonzalez@gmail.com>2010-08-27 16:49:07 -0400
commitaf9864dcc439bf8d04f4ade248725cc217f66d56 (patch)
tree967e4a3064049a961f975c8ec15f9305ea183d19 /ui/jquery.ui.dialog.js
parent1e28040cf358d0fe81ee83a2e35d7dbb65362afa (diff)
downloadjquery-ui-af9864dcc439bf8d04f4ade248725cc217f66d56.tar.gz
jquery-ui-af9864dcc439bf8d04f4ade248725cc217f66d56.zip
Dialog: Don't return true when we don't want to cancel events. Fixes #3523 - Dialog: onclick return value ignored.
Diffstat (limited to 'ui/jquery.ui.dialog.js')
-rw-r--r--ui/jquery.ui.dialog.js5
1 files changed, 4 insertions, 1 deletions
diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js
index 44f5cbbbc..1f3bd60f0 100644
--- a/ui/jquery.ui.dialog.js
+++ b/ui/jquery.ui.dialog.js
@@ -693,7 +693,10 @@ $.extend($.ui.dialog.overlay, {
if ($.ui.dialog.overlay.instances.length) {
$(document).bind($.ui.dialog.overlay.events, function(event) {
// stop events if the z-index of the target is < the z-index of the overlay
- return ($(event.target).zIndex() >= $.ui.dialog.overlay.maxZ);
+ // we cannot return true when we don't want to cancel the event (#3523)
+ if ($(event.target).zIndex() < $.ui.dialog.overlay.maxZ) {
+ return false;
+ }
});
}
}, 1);