aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Build: Update some npm dependenciesMichał Gołębiowski-Owczarek2022-01-201-2/+2
| | | | | | Unfortunately, we cannot update all of them to their latest versions as some of them now require Node.js 12 and we need to be able to build on Node 10 as that's what our Jenkins runs.
* Widget: Optimize attachment of the _untrackClassesElement listenerMichał Gołębiowski-Owczarek2022-01-154-3/+112
| | | | | | | | | | | | | | | jQuery UI 1.13.0 changed the logic attaching the `_untrackClassesElement` listener in the `_classes` widget method; one of the side effects was calling `this._on` for each node that needed the listener. That caused a severe performance degradation for large comboboxes as each `_on` jQuery UI call causes a jQuery `add` call that calls Sizzle's `uniqueSort` underneath. Instead, collect the nodes that need the listener and then, outside of the loop, create a jQuery object out of them and attach the listener once. That's still slower than the jQuery 1.12 version but only slightly: 936 ms to 1.03s on a very large list on a recent MacBook Pro, compared to ~30 seconds before this patch. Fixes gh-2014 Closes gh-2037
* Build: Add Felix to .mailmap, update AUTHORS.txtMichał Gołębiowski-Owczarek2022-01-152-0/+3
| | | | | | Beyond the `AUTHORS.txt` changes, this accounts for a recent email change in one of the commits. Closes gh-2039
* Autocomplete: Rewrite with a delay instead of appending the live regionBen Mullins2022-01-052-38/+55
| | | | | | | | | This fixes the issue caused by https://bugs.jqueryui.com/ticket/9357. We now empty the live region instead of appending to it, and we do so after a brief timeout so the live region isn't updated on every mousemove event or when quickly traversing through options. Fixes gh-2002 Closes gh-2031
* Build: Add extra Github action job for PR required checks configurationFelix Nagel2021-12-061-0/+9
|
* Build: Switch from Travis to GitHub actionsFelix Nagel2021-11-304-14/+51
| | | Closes gh-2021
* Widget: Make contextless widget construction workMichał Gołębiowski-Owczarek2021-11-192-1/+13
| | | | | | | | | | | | | | Due to the fact the widget factory code is now in strict mode, the check for being called without using the `new` keyword started breaking if you save the widget constructor to a variable before calling it: ```js var customWidget = $.custom.customWidget; customWidget( {}, elem ); ``` as then `this` is undefined and checking for `this._createWidget` crashes. Account for that with an additional check. Fixes gh-2015 Closes gh-2019
* Sortable: Fix positioning when moving a Draggable item into a SortableMichał Gołębiowski-Owczarek2021-11-152-0/+63
| | | | | | | | | PR gh-1793 removed setting `this.offset.parent` in the Draggable `refreshPositions` method which broke position calculations when moving a Draggable item into a connected Sortable. restore that assignment. Ref gh-1793 Fixes gh-2001 Closes gh-2009
* Sortable: Allow 0-height containers to be sortable as in 1.12.1Michał Gołębiowski-Owczarek2021-11-082-64/+110
| | | | | | | | | Note that container specific events will not fire when the dragged element is interacting with zero height containers. Fixes gh-1998 Closes gh-2008 Co-authored-by: A. Wells <borgboyone@users.noreply.github.com>
* Tooltip: Don't crash on empty contentJosep Sanz2021-11-082-1/+74
| | | | | | | | | | | | | | | Commit 1f2011ece removed a `try-catch` around triggering the `remove` handlers in the `jQuery.cleanData` override. The `try-catch` was meant for old IE but it was also catching an error coming from the tooltip `remove` handler depending on being able to find a relevant tooltip. The `_find` method returns `null`, though, when the tooltip cotent is empty. Instead of restoring the `try-catch`, handle the `null` case in the `remove` handler. Fixes gh-1990 Closes gh-1994 Co-authored-by: Claas Augner <github@caugner.de> Co-authored-by: Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
* Docs: Update the bug tracker from bugs.jqueryui.com to GitHubMichał Gołębiowski-Owczarek2021-10-074-8/+5
| | | | | | Also, remove the Weekly Meetings section from README as the meetings are no longer happening. Closes gh-1972
* Build: Updating the main version to 1.13.1-pre.Michał Gołębiowski-Owczarek2021-10-071-1/+1
|
* Tests: Take development jQuery versions from releases.jquery.comMichał Gołębiowski-Owczarek2021-09-291-2/+2
| | | | code.jquery.com is now used just for the specific versions.
* Tests: Load the TestSwarm listener via HTTPSMichał Gołębiowski-Owczarek2021-09-292-2/+2
|
* Release: Update the download.jqueryui.com dependencyMichał Gołębiowski-Owczarek2021-09-271-1/+1
|
* Theme: Revert three theme commits that are causing styling issues (#1983)Michał Gołębiowski-Owczarek2021-09-261-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Revert "Theme: Removes css for ui-state-checked its not used any more" This reverts commit 1b0e947f46bc1261b15816f2dcbd239d83a86335. * Revert "Theme: Replace missing definition for default icons" This reverts commit dde9b83df61d1d676e66cb2a2f7970dd44a05137. * Revert "Theme: Switch icon background to use bgColorContent" This reverts commit 265b8f5e533923b9b4c9cbd9f1dd7b7785423381. This reverts three commits: * Theme: Removes css for ui-state-checked its not used any more https://github.com/jquery/jquery-ui/commit/1b0e947f46bc1261b15816f2dcbd239d83a86335 (https://github.com/jquery/jquery-ui/pull/1753) * Theme: Replace missing definition for default icons https://github.com/jquery/jquery-ui/commit/dde9b83df61d1d676e66cb2a2f7970dd44a05137 * Theme: Switch icon background to use bgColorContent https://github.com/jquery/jquery-ui/commit/265b8f5e533923b9b4c9cbd9f1dd7b7785423381 which caused styling issues when compared to UI 1.12.1. This unfixes a few issues: * https://github.com/jquery/download.jqueryui.com/issues/335 * https://bugs.jqueryui.com/ticket/15059 * https://forum.jquery.com/topic/checkboxradio-widget-checkbox-click-doesn-t-work-with-ui-lightness-theme-22-9-2016 However, old & known issues are better than new & unknown ones, especially with our current very limited resources. Closes gh-1983
* Theme: Fix blank icons having a backgroundMichał Gołębiowski-Owczarek2021-09-251-1/+4
| | | | | | | | | | | | A fix from 43254468de7d69b5422e667ba7ebbe864fc34a63 introduced a rule setting `background-image` of a blank icon to none. However, the selector used for that rule had lower specificity than another one: `.ui-button .ui-icon` which caused dashes being shown over the icons. We needed to increase the specificity of the `.ui-icon-blank` rule past the above selector and past `.ui-button:hover .ui-icon`. We're doing it by repeating the class name three times. Closes gh-1987
* Build: Require jQuery `>=1.8.0 <4.0.0`, not `>=1.6` in bower.jsonMichał Gołębiowski-Owczarek2021-09-251-1/+1
|
* Docs: Update jQuery used for demos to 3.6.0Michał Gołębiowski-Owczarek2021-09-254-4267/+4124
| | | | | jQuery 1.12.4 misses some Core APIs that jQuery UI depends on and that are not polyfilled in demos.
* Tests: Update the default jQuery version from 1.12.4 to 3.6.0Michał Gołębiowski-Owczarek2021-09-251-1/+1
|
* Effect: Define the jQuery variable before jQuery Color gets importedMichał Gołębiowski-Owczarek2021-09-032-5/+24
| | | | | | | | | | We need to create a local jQuery because jQuery Color relies on it and the global may not exist with AMD and a custom build (trac-10199). This worked in UI 1.12 but stopped in 1.13 as jQuery Color is now sourced as an AMD module and the variable started being defined after jQuery Color code. To restore the proper order, move the variable declaration to a separate small module loaded before jQuery Color. Closes gh-1973
* Release: Update the download.jqueryui.com dependencyMichał Gołębiowski-Owczarek2021-09-021-1/+1
| | | | The latest version contains small tweaks to the "use strict" pragma placement.
* Build: Update npm dependenciesMichał Gołębiowski-Owczarek2021-09-021-6/+6
|
* Release: Update the download.jqueryui.com dependencyMichał Gołębiowski-Owczarek2021-08-261-1/+1
| | | | | | This is needed to make `"use strict"` pragmas not stripped out during the build. Closes gh-1969
* Docs: Update removal comments to mention 1.14, not 1.13Michał Gołębiowski-Owczarek2021-08-263-3/+3
| | | | | | | | | We're not removing any deprecated API or legacy browser support in 1.13, re-target comments to mention 1.14. It's not guaranteed 1.14 will ever get released but if it will, it sounds like a good moment to do those removals. Closes gh-1970
* Release: Update the download.jqueryui.com dependencyMichał Gołębiowski-Owczarek2021-08-061-1/+1
|
* Release: Abort on packager errorsMichał Gołębiowski-Owczarek2021-08-061-11/+15
|
* Release: Update dependencies for the 1.13 releaseMichał Gołębiowski-Owczarek2021-08-061-3/+3
| | | | Closes gh-1966
* Build: Don't save temporary npm dependencies to package.jsonMichał Gołębiowski-Owczarek2021-08-061-1/+1
| | | | | | | | Past npm versions required the `--save` flag to save anything in `package.json` when installing packages but newer ones do this by default. Pass `--no-save` to restore the original behavior in the `release-test.js` script. Ref gh-1966
* Build: Don't publish dist/cdn to npmMichał Gołębiowski-Owczarek2021-08-041-0/+1
|
* Build: Update dependencies passed to jquery-releaseMichał Gołębiowski-Owczarek2021-08-041-2/+2
| | | | | The older versions were not compatible with Node.js 10 & newer. Closes gh-1963
* Docs: Update AUTHORS.txtMichał Gołębiowski-Owczarek2021-08-041-0/+32
| | | Closes gh-1964
* Build: Fix package generationMichał Gołębiowski-Owczarek2021-08-041-1/+14
| | | | | | | | | jQuery UI 1.12.1 was released using an outdated (at the time of its release) version of the download.jqueryui.com package; the latest ones wouldn't generate relevant JS files. This commit accounts for the changes so that the latest version can be used. Closes gh-1965
* Datepicker: Get selectedDay from data-date instead of element contentsc-lambert2021-07-121-1/+2
| | | | | This makes datepicker work fine even if translation software modifies texts on the page. Closes gh-1943
* Build: Migrate from JSHint & JSCS to ESLintMichał Gołębiowski-Owczarek2021-06-07251-61556/+1486
| | | | | Fixes #15393 Closes gh-1958
* Datepicker: Improve callbacks test for onUpdateDatepickerPatrick McKay2021-05-211-2/+7
| | | | Make sure the custom element added by the onUpdateDatepicker callback still exists and is not duplicated after calling refresh and setDate.
* Datepicker: Add option for onUpdateDatepicker callbackPatrick McKay2021-05-212-3/+25
| | | | | | Add a new option named onUpdateDatepicker that allows a custom callback to be provided. If provided, the callback is called at the end of $.datepicker._updateDatepicker.
* Fix: Adapt datpicker.js for a11yMikolaj Wolicki2021-05-151-4/+9
|
* All: Drop $.ui.escapeSelector in favor of $.escapeSelectorMichał Gołębiowski-Owczarek2021-05-147-37/+35
| | | | Fixes #14991 Closes gh-1957
* Datepicker: Make sure text option are text, shorten HTML stringsMichał Gołębiowski-Owczarek2021-05-122-21/+166
| | | | | | | | Instead of using enormous HTML strings, various elements are now constructed using jQuery APIs. This makes it more obvious user-provided data is used correctly. Fixes #15284 Closes gh-1953
* Position: Make sure `of` is treated as a CSS selectorMichał Gołębiowski-Owczarek2021-05-042-2/+25
| | | Closes gh-1955
* Datepicker: Make sure altField is treated as a CSS selectorMichał Gołębiowski-Owczarek2021-05-042-3/+21
| | | Closes gh-1954
* Tests: Accept delayed focusout in IE with jQuery 1.8Michał Gołębiowski-Owczarek2021-04-161-2/+13
| | | | | | In IE with jQuery 1.8 focusout may not happen immediately so some checks need to be done later. Closes gh-1952
* Tests: Fix the "dialog: core: focus tabbable" test in IEMichał Gołębiowski-Owczarek2021-03-161-6/+26
| | | | | | | | | | | | | In IE in jQuery 3.4+ a sequence: ```js $( inputNode ).trigger( "focus" ).trigger( "blur" ).trigger( "focus" ); ``` doesn't end up with a focused input. However, in this test we only want to check that the last focused input receives the focus back when `_focusTabbable()` is called which in reality doesn't happen so quickly so let's avoid the issue by waiting a bit. Ref jquery/jquery#4856 Closes gh-1951
* Build: Fix the new htmllint error regexMichał Gołębiowski-Owczarek2021-03-101-1/+1
| | | | | | | | | Some bad pages are being detected as Catalan randomly which makes the build fail. This is reproducible both locally & on Travis. PR gh-1949 added a new regex to account for this error but it didn't escape parens properly so it's not matching the problematic error message. Ref gh-1949 Closes gh-1950
* Tests: Make some number comparisons less strictMichał Gołębiowski-Owczarek2021-03-092-6/+24
| | | | | | | | | | Some of the APIs return fractional values in newer jQueries, making comparisons sometimes not being 100% accurate. Allow some delta. This is similar to what was already done in 98b539171b6e805fa79346a5e9896865e5213b9c but a few cases affecting IE and/or Edge Legacy were missed. Closes gh-1947
* Build: Add a new htmllint error regexMichał Gołębiowski-Owczarek2021-03-091-1/+2
| | | | | | | Some bad pages are being detected as Catalan randomly which makes the build fail. This is reproducible both locally & on Travis. This commit adds a new regex to account for this error. Closes gh-1949
* Build: Add jQuery 3.6.0, update Migrate from 3.3.1 to 3.3.2Michał Gołębiowski-Owczarek2021-03-0910-11/+10943
| | | Closes gh-1948
* Dialog: Workaround broken focus re-triggering in jQuery 3.4/3.5Michał Gołębiowski-Owczarek2021-02-221-10/+22
| | | | | | | | | | | Focus re-triggering in jQuery 3.4/3.5 makes the original element have its focus event propagated last, breaking the re-targeting. Trigger focus in a delay in addition if needed to avoid the issue. This fixes the "interaction between overlay and other dialogs" core dialog test when tested against jQuery 3.4/3.5. Closes gh-1946 Ref jquery/jquery#4382
* Tests: Account for an extra noop focus/blur listener in jQuery >=3.4Michał Gołębiowski-Owczarek2021-02-201-21/+22
| | | | | | | | | | | | | | | | | | jQuery >=3.4.0 uses a special focus/blur handler pair needed to fix various issues with checkboxes/radio buttons as well as being able to pass data in focus triggers. This leaves extra focus & blur events if any of these events were ever listened to at a particular element. We've started skipping these handlers in the `domEqual` assertion in gh-1930 but we missed a case where an event is triggered before any handler is attached - jQuery >=3.4.0 attaches then an extra noop listener just to force the code path to go through the setup code before the trigger happens. We now skip this extra handler as well. This fixes a test failure in "dialog: methods" destroy tests. Closes gh-1945 Ref jquery/jquery#4496 Ref gh-1930