aboutsummaryrefslogtreecommitdiffstats
path: root/tests/unit/selectmenu/core.js
Commit message (Collapse)AuthorAgeFilesLines
* Widget: Optimize attachment of the _untrackClassesElement listenerMichał Gołębiowski-Owczarek2022-01-151-0/+30
| | | | | | | | | | | | | | | jQuery UI 1.13.0 changed the logic attaching the `_untrackClassesElement` listener in the `_classes` widget method; one of the side effects was calling `this._on` for each node that needed the listener. That caused a severe performance degradation for large comboboxes as each `_on` jQuery UI call causes a jQuery `add` call that calls Sizzle's `uniqueSort` underneath. Instead, collect the nodes that need the listener and then, outside of the loop, create a jQuery object out of them and attach the listener once. That's still slower than the jQuery 1.12 version but only slightly: 936 ms to 1.03s on a very large list on a recent MacBook Pro, compared to ~30 seconds before this patch. Fixes gh-2014 Closes gh-2037
* Build: Migrate from JSHint & JSCS to ESLintMichał Gołębiowski-Owczarek2021-06-071-0/+1
| | | | | Fixes #15393 Closes gh-1958
* Tests: Ensure no timers are running at the end of each test (#1920)Michał Gołębiowski-Owczarek2020-05-161-2/+3
| | | | | | | | | | | | | This helps fix issues that make tooltip tests sometimes fail when run against jQuery 3.2 or newer due to timing differences. Details: * Add the `moduleAfterEach` function ensuring no timers are running. * Attach this function via `common.testWidget`. * Attach this function to most test suites. * Add a tooltip test helper cleaning up leftover timers. * Rename legacy `setup`/`teardown` hooks to `beforeEach`/`afterEach`. Closes gh-1920
* All: Migrate away from deprecated/removed Core APIsMichał Gołębiowski-Owczarek2019-12-081-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary of the changes: * Build: Add jQuery 3.2.0-3.4.1 to versions UI can be tested against * Build: Load jQuery & Migrate via HTTPS * Build: Add package-lock.json to .gitignore * Build: Update jQuery Migrate from 3.0.0 to 3.1.0 * Build: Allow to run tests against jQuery 3.x-git * Build: Fix formatting according to JSCS rules * Build: Disable JSCS for the inlined jQuery Color * All: Switch from $.isArray to Array.isArray (jQuery.isArray will be removed in jQuery 4.0) * All: Switch from `$.isFunction( x )` to `typeof x === "function"` (jQuery.isFunction will be removed in jQuery 4.0) * All: Inline jQuery.isWindow as it'll be removed in jQuery 4.0 * Effects: Fix a timing issue in a variable declaration. Previously, a jQuery object was created, chained & assigned to a variable that was then accessed in a callback used inside of this chained definition. Due to a timing difference in when the callback fired for the first time in latest jQuery master, it was being called before the variable was defined. * Tests: Make dialog & draggable unit tests less strict (newest jQuery returns fractional results in some cases, making comparisons fail when there's a tiny difference) * All: Migrate from $.trim to bare String.prototype.trim (jQuery.trim will be deprecated in jQuery 3.5) Closes gh-1901
* Menu: Ignore mouse events triggered due to page scrollingScott González2017-05-021-2/+2
| | | | | Fixes #9356 Closes gh-1806
* Selectmenu: Don't render options with the `hidden` attributeScott González2016-11-161-0/+26
| | | | Fixes #15098
* Menu: Support number pad keyboard inputFelix Nagel2016-08-241-15/+31
| | | | | Fixes #15031 Closes gh-1732
* Selectmenu: Shift to use no globalsAmanpreet Singh2016-04-141-75/+84
|
* Selectmenu: Prepend icon and move overflow to text spanAlexander Schmitz2016-03-301-1/+1
| | | | | Fixes #14938 Closes gh-1685
* Selectmenu: Fixed selectmenu icon float rightAlexander Schmitz2016-02-241-1/+5
| | | | | | | Also removes the icon space as its not needed with a floated icon Fixes #14914 Closes gh-1671
* Selectmenu: Handle form resetsJörn Zaefferer2015-10-271-0/+18
| | | | | Fixes #12236 Ref gh-1550
* Tests: Fix button space assertions on IE8Jörn Zaefferer2015-10-251-7/+7
| | | | | IE8 still doesn't keep the space in the text (or HTML) representation. We don't really care, so adding more trims in these tests as well.
* Selectmenu: Address review commentsAlexander Schmitz2015-10-081-3/+2
|
* Selectmenu: update to use button cssAlexander Schmitz2015-10-071-6/+7
| | | | This ensures consistency between different form elements
* Selectmenu: Style updatesAlexander Schmitz2015-09-111-37/+37
| | | | Ref #14246
* Selectmenu: Move selectmenu into widgets folderAlexander Schmitz2015-08-081-1/+1
| | | | Ref #13885
* Tests: Rename filesScott González2015-04-091-0/+332
Ref gh-1528