Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Allow higher cyclomatic complexity in functions that sanely use switch ↵ | Scott González | 2012-12-06 | 1 | -0/+1 |
| | | | | statements. | ||||
* | Dialog: Restore inline styles for dimensions/display. Fixes #8119 - Dialog: ↵ | Scott González | 2012-12-05 | 1 | -6/+7 |
| | | | | Destroying a dialog leaves some styles changed. | ||||
* | Dialog: Remove width, min-height, height styles on destroy. Fixes #8119 - ↵ | Scott González | 2012-12-04 | 1 | -0/+5 |
| | | | | Dialog: Destroying a dialog leaves some styles changed. | ||||
* | Revert "Dialog: Cleanup style properties on _destroy. Reenables style check ↵ | Scott González | 2012-12-04 | 1 | -5/+0 |
| | | | | | | in domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers." This reverts commit d687a1b10d1e176a6a8dd4420f1ea3a890640da0. | ||||
* | Dialog: Refactor _createOverlay and _destroyOverlay to use widget methods ↵ | Jörn Zaefferer | 2012-12-04 | 1 | -7/+9 |
| | | | | and properties. | ||||
* | Dialog: Remove the instance-storing for the overlay, just create one ↵ | Jörn Zaefferer | 2012-12-04 | 1 | -20/+7 |
| | | | | whenever it is needed. Heavily simplifies the code, while the memorly leak should be hardly an issue anymore, since fixed positioning restricts the overlay size to the window dimensions. Fixes #6058 - Dialog overlays are not properly reused when multiple instances of a Dialog exist. | ||||
* | Dialog: Cleanup style properties on _destroy. Reenables style check in ↵ | Jörn Zaefferer | 2012-12-04 | 1 | -0/+5 |
| | | | | domEqual, while removing commented and unnecessary old code. Fixes #8119 - Dialog: Destroying a dialog leaves style, scrollleft, and scrolltop leftovers. | ||||
* | Dialog: Ensure all animations finish and clean up themselve when destroying ↵ | Jörn Zaefferer | 2012-11-30 | 1 | -1/+1 |
| | | | | dialog. Fixes #5860 - Dialog: Destroying a dialog during animated close leaves .ui-effects-wrapper in DOM. | ||||
* | Dialog: Use consistent code for appending to body | Jörn Zaefferer | 2012-11-29 | 1 | -1/+1 |
| | |||||
* | Dialog: Extract setting the title into a _title method, use .text() to ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -4/+9 |
| | | | | prevent XSS. Fixes #6016 - Dialog: Title XSS Vulnerability. | ||||
* | Dialog: Don't focus dialog when mousedown is on close button. Fixes #8838 - ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -3/+8 |
| | | | | Dialog: Close icon does not work in dialog larger than the window in IE. | ||||
* | Dialog: Update position when size is changed. Fixes #8789 - Dialog does not ↵ | Kris Borchers | 2012-11-26 | 1 | -0/+1 |
| | | | | close for first click on chrome. | ||||
* | Dialog: Follow-up to c77ca67 - exclude button options from properties to ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -5/+8 |
| | | | | create the button. | ||||
* | Dialog: Follow-up to 9fe3a62d8 - also deprecate string notation for position ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -60/+41 |
| | | | | option. | ||||
* | Dialog: Improve _destroy method, detaching dialog content from wrapper ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -4/+4 |
| | | | | instead of appending to body. | ||||
* | Dialog: Refactor overlay handling into two instance methods. Remove ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -41/+26 |
| | | | | unaddressable TODOs. | ||||
* | Dialog: Move array notation support for position option to backCompat check. ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -23/+57 |
| | | | | Fixes #8824 - Deprecate array notation for position option. | ||||
* | Dialog: Removed broken disabled option from dialog, defuse disable/enable ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -0/+7 |
| | | | | methods. Disabling dialogs is not supported. | ||||
* | Dialog: Extend autofocus, starting with [autofocus], then :tabbable content, ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -7/+15 |
| | | | | then buttonpane, then close button, then dialog. Fixes #4731 - Dialog: Add option to set which element gains focus on open | ||||
* | Dialog: Pass through icons and showText (as 'text') options to button. Fixes ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -2/+4 |
| | | | | #6830 - Allow Icons to be specified for Dialog buttons. | ||||
* | Dialog: Tiny code improvements | Jörn Zaefferer | 2012-11-26 | 1 | -2/+4 |
| | |||||
* | Dialog: Remove uuid and getTitleId. Leftovers from ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -11/+0 |
| | | | | 240b22b1439df22408c5782e640e98cb335c7a2e. | ||||
* | Dialog: Remove busted ui-dialog-disabled class, shouldn't be there. Removed ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -11/+0 |
| | | | | outdated TODOs. | ||||
* | Dialog: Button is now a fixed dependency, so remove the check | Jörn Zaefferer | 2012-11-26 | 1 | -6/+4 |
| | |||||
* | Dialog: Remove useless tmp vars. | Jörn Zaefferer | 2012-11-26 | 1 | -7/+3 |
| | |||||
* | Dialog: Extracting wrapper creation into _createWrapper. Merging the two ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -64/+62 |
| | | | | keydown handlers into one. | ||||
* | Dialog: Extract button pane creation into _createButtonPane | Jörn Zaefferer | 2012-11-26 | 1 | -13/+13 |
| | |||||
* | Dialog: Refactor _create, extracting title bar creation in _createTitlebar | Jörn Zaefferer | 2012-11-26 | 1 | -41/+48 |
| | |||||
* | Dialog: Refactor uiDialogTitlebar variable, use this.uiDialogTitlebar ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -7/+5 |
| | | | | instead. Wasn't needed anymore (previous refactorings). | ||||
* | Dialog: Refactor the mousedown-bind call to use _on, removing the need for ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -15/+15 |
| | | | | the uiDialog closure. Use this.uiDialog and remove the variable. | ||||
* | Dialog: Remove outdated TODO | Jörn Zaefferer | 2012-11-26 | 1 | -2/+0 |
| | |||||
* | Dialog: Have _makeResizable look at options instead of passing handles. | Jörn Zaefferer | 2012-11-26 | 1 | -3/+3 |
| | |||||
* | Dialog: Finish refactoring _setOption, getting rid of unnecessary switch (no ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -47/+50 |
| | | | | fallthroughs). | ||||
* | Dialog: Have _createButtons access the buttons option directly. Start ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -6/+8 |
| | | | | refactoring _setOption, no need for switch. | ||||
* | Dialog: Refactor _setOption to call _super early. Move dialogClass update ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -7/+8 |
| | | | | above that to access old option value. | ||||
* | Dialog: Use button widget for close button (was already listed as dependency) | Jörn Zaefferer | 2012-11-26 | 1 | -14/+12 |
| | |||||
* | Dialog: Focus tabbable only when dialog lost focus before. | Jörn Zaefferer | 2012-11-26 | 1 | -8/+15 |
| | |||||
* | Dialog: Remove attroperty workaround for title attribute. Make the default ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -7/+2 |
| | | | | null, as it should be. No back-compat, as the behaviour doesn't change. | ||||
* | Dialog: Only add the new dialogClass, not the base classes when changing the ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -2/+1 |
| | | | | option. | ||||
* | Dialog: Use $.isEmptyObject() to check if there a button-option properties | Jörn Zaefferer | 2012-11-26 | 1 | -9/+2 |
| | |||||
* | Dialog: Trigger focus event when dialog is moved to top. | Jörn Zaefferer | 2012-11-26 | 1 | -2/+1 |
| | |||||
* | Dialog: Remove deprecated disableSelection() usage. | Jörn Zaefferer | 2012-11-26 | 1 | -4/+0 |
| | |||||
* | Dialog: Fix yoda-if, remove unnecessary TODOs; add missing callbacks to ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -4/+1 |
| | | | | commons test | ||||
* | Dialog: Inline code review | Jörn Zaefferer | 2012-11-26 | 1 | -5/+53 |
| | |||||
* | Dialog: move to top when opening again, and focus as if opened from scratch. | Jörn Zaefferer | 2012-11-26 | 1 | -0/+2 |
| | |||||
* | Dialog: Keep focus inside modal dialog, by handling focus events on elements ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -11/+30 |
| | | | | outside of it | ||||
* | Dialog: Improve accessibilty - add an aria-describedby attribute on the ↵ | Jörn Zaefferer | 2012-11-26 | 1 | -0/+10 |
| | | | | dialog if there is nothing yet in the dialog content. Partial fix for: | ||||
* | Updated all widgets to use proper data keys when getting plugin instances. | Scott González | 2012-11-09 | 1 | -4/+4 |
| | |||||
* | Dialog: Don't use .attr( props, true ). | Scott González | 2012-11-05 | 1 | -6/+9 |
| | |||||
* | Mixed spaces and tabs removed | Corey Frang | 2012-10-29 | 1 | -3/+3 |
| |