aboutsummaryrefslogtreecommitdiffstats
path: root/ui
Commit message (Collapse)AuthorAgeFilesLines
* Widget: Optimize attachment of the _untrackClassesElement listenerMichał Gołębiowski-Owczarek2022-01-151-3/+7
| | | | | | | | | | | | | | | jQuery UI 1.13.0 changed the logic attaching the `_untrackClassesElement` listener in the `_classes` widget method; one of the side effects was calling `this._on` for each node that needed the listener. That caused a severe performance degradation for large comboboxes as each `_on` jQuery UI call causes a jQuery `add` call that calls Sizzle's `uniqueSort` underneath. Instead, collect the nodes that need the listener and then, outside of the loop, create a jQuery object out of them and attach the listener once. That's still slower than the jQuery 1.12 version but only slightly: 936 ms to 1.03s on a very large list on a recent MacBook Pro, compared to ~30 seconds before this patch. Fixes gh-2014 Closes gh-2037
* Autocomplete: Rewrite with a delay instead of appending the live regionBen Mullins2022-01-051-4/+9
| | | | | | | | | This fixes the issue caused by https://bugs.jqueryui.com/ticket/9357. We now empty the live region instead of appending to it, and we do so after a brief timeout so the live region isn't updated on every mousemove event or when quickly traversing through options. Fixes gh-2002 Closes gh-2031
* Widget: Make contextless widget construction workMichał Gołębiowski-Owczarek2021-11-191-1/+1
| | | | | | | | | | | | | | Due to the fact the widget factory code is now in strict mode, the check for being called without using the `new` keyword started breaking if you save the widget constructor to a variable before calling it: ```js var customWidget = $.custom.customWidget; customWidget( {}, elem ); ``` as then `this` is undefined and checking for `this._createWidget` crashes. Account for that with an additional check. Fixes gh-2015 Closes gh-2019
* Sortable: Fix positioning when moving a Draggable item into a SortableMichał Gołębiowski-Owczarek2021-11-151-0/+6
| | | | | | | | | PR gh-1793 removed setting `this.offset.parent` in the Draggable `refreshPositions` method which broke position calculations when moving a Draggable item into a connected Sortable. restore that assignment. Ref gh-1793 Fixes gh-2001 Closes gh-2009
* Sortable: Allow 0-height containers to be sortable as in 1.12.1Michał Gołębiowski-Owczarek2021-11-081-64/+57
| | | | | | | | | Note that container specific events will not fire when the dragged element is interacting with zero height containers. Fixes gh-1998 Closes gh-2008 Co-authored-by: A. Wells <borgboyone@users.noreply.github.com>
* Tooltip: Don't crash on empty contentJosep Sanz2021-11-081-1/+4
| | | | | | | | | | | | | | | Commit 1f2011ece removed a `try-catch` around triggering the `remove` handlers in the `jQuery.cleanData` override. The `try-catch` was meant for old IE but it was also catching an error coming from the tooltip `remove` handler depending on being able to find a relevant tooltip. The `_find` method returns `null`, though, when the tooltip cotent is empty. Instead of restoring the `try-catch`, handle the `null` case in the `remove` handler. Fixes gh-1990 Closes gh-1994 Co-authored-by: Claas Augner <github@caugner.de> Co-authored-by: Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
* Effect: Define the jQuery variable before jQuery Color gets importedMichał Gołębiowski-Owczarek2021-09-032-5/+24
| | | | | | | | | | We need to create a local jQuery because jQuery Color relies on it and the global may not exist with AMD and a custom build (trac-10199). This worked in UI 1.12 but stopped in 1.13 as jQuery Color is now sourced as an AMD module and the variable started being defined after jQuery Color code. To restore the proper order, move the variable declaration to a separate small module loaded before jQuery Color. Closes gh-1973
* Docs: Update removal comments to mention 1.14, not 1.13Michał Gołębiowski-Owczarek2021-08-263-3/+3
| | | | | | | | | We're not removing any deprecated API or legacy browser support in 1.13, re-target comments to mention 1.14. It's not guaranteed 1.14 will ever get released but if it will, it sounds like a good moment to do those removals. Closes gh-1970
* Datepicker: Get selectedDay from data-date instead of element contentsc-lambert2021-07-121-1/+2
| | | | | This makes datepicker work fine even if translation software modifies texts on the page. Closes gh-1943
* Build: Migrate from JSHint & JSCS to ESLintMichał Gołębiowski-Owczarek2021-06-07132-721/+1180
| | | | | Fixes #15393 Closes gh-1958
* Datepicker: Add option for onUpdateDatepicker callbackPatrick McKay2021-05-211-1/+7
| | | | | | Add a new option named onUpdateDatepicker that allows a custom callback to be provided. If provided, the callback is called at the end of $.datepicker._updateDatepicker.
* Fix: Adapt datpicker.js for a11yMikolaj Wolicki2021-05-151-4/+9
|
* All: Drop $.ui.escapeSelector in favor of $.escapeSelectorMichał Gołębiowski-Owczarek2021-05-146-29/+35
| | | | Fixes #14991 Closes gh-1957
* Datepicker: Make sure text option are text, shorten HTML stringsMichał Gołębiowski-Owczarek2021-05-121-21/+115
| | | | | | | | Instead of using enormous HTML strings, various elements are now constructed using jQuery APIs. This makes it more obvious user-provided data is used correctly. Fixes #15284 Closes gh-1953
* Position: Make sure `of` is treated as a CSS selectorMichał Gołębiowski-Owczarek2021-05-041-1/+6
| | | Closes gh-1955
* Datepicker: Make sure altField is treated as a CSS selectorMichał Gołębiowski-Owczarek2021-05-041-1/+1
| | | Closes gh-1954
* Dialog: Workaround broken focus re-triggering in jQuery 3.4/3.5Michał Gołębiowski-Owczarek2021-02-221-10/+22
| | | | | | | | | | | Focus re-triggering in jQuery 3.4/3.5 makes the original element have its focus event propagated last, breaking the re-targeting. Trigger focus in a delay in addition if needed to avoid the issue. This fixes the "interaction between overlay and other dialogs" core dialog test when tested against jQuery 3.4/3.5. Closes gh-1946 Ref jquery/jquery#4382
* Focusable: Fix handling of `visibility: collapse`Paul Capron2020-10-141-1/+1
| | | | | | | | | | | | | | "collapse" is similar to "hidden", with a slight difference in the case of tr/tbody/td/colgroup elements. See https://www.w3.org/TR/CSS22/visufx.html#visibility See https://www.w3.org/TR/CSS22/tables.html#dynamic-effects See https://developer.mozilla.org/en-US/docs/Web/CSS/visibility#Table_example "visibility: collapse" elements are always not focusable, though. Commit d3025968f34 introduced a regression by testing with `!== "hidden"` instead of `=== "visible"`. Closes gh-1843
* Widget: Fix boolean option when under use strictHrvoje Novosel2020-10-061-0/+2
| | | | | | | | | | | | | | Fix for `options === true` when using jQuery UI under `use strict`, which throws: ``` Uncaught TypeError: Cannot create property 'complete' on boolean 'true' ``` on line: ```js options.complete = callback; ``` Closes gh-1931
* Resizable: Fix CSP violation (style unsafe-inline)Jérémy Munsch2020-08-111-2/+3
|
* All: Remove a leftover empty fileMichał Gołębiowski-Owczarek2020-07-241-0/+0
| | | Closes gh-1933
* Menu: Account for scrollbars in jQuery 3.2Michał Gołębiowski-Owczarek2020-07-231-2/+14
| | | | | | | | | | jQuery >=3.2 doesn't include scrollbars in `.height()`, this commit switches it to `.innerHeight()` which does so in jQuery >=3.3. In jQuery 3.2 it doesn't either so include scrollbars in innerHeight, add it back. Using `.innerHeight()` instead of `.height()` should be fine as menu doesn't define padding styles. Closes gh-1929
* All: Drop support for jQuery 1.7Michał Gołębiowski-Owczarek2020-07-222-69/+4
| | | Closes gh-1923
* All: Resolve most jQuery Migrate warningsMichał Gołębiowski-Owczarek2020-05-165-3/+5
| | | Closes gh-1919
* Build: Rename jquery-1-7 to jquery-patchMichał Gołębiowski-Owczarek2020-05-162-1/+1
| | | | | The file now contains many more than just jQuery 1.7 patches. Closes gh-1917
* Build: Update jQuery Simulate, jQuery Migrate & jQuery ColorMichał Gołębiowski-Owczarek2020-05-163-682/+770
| | | | | | The jQuery Simulate & jQuery Color updates are needed for compatibility with jQuery master, a future jQuery 4. Closes gh-1914
* Datepicker: Fix Hungarian localization to use uppercase for first charactersFatér Zsolt2020-03-231-4/+4
|
* Datepicker: Add German localizationFlorian Wegscheider2020-03-231-0/+38
|
* Datepicker: Fixed current instance memory leak and added unit testcasesjigar gala2020-03-231-0/+1
|
* All: Remove usage of jQuery positional selectorsMichał Gołębiowski-Owczarek2020-01-224-5/+28
| | | | | | | | | | | | | | | | | jQuery positional selectors () have been deprecated in [jQuery 3.4.0](https://blog.jquery.com/2019/04/10/jquery-3-4-0-released/) and they'll be removed in jQuery 4.0.0. This PR removes their usage. Most of the changes were possible without changing public API. However, dropping `:even` usage required a change to the [`header` option](https://api.jqueryui.com/accordion/#option-header) of the accordion widget. I made it an optional function; this will need to be documented. The polyfill for `.even()` & `.odd()` is added for jQuery <3.5.0. There was no usage of the :odd selector in the code but the `.odd()` method is also polyfilled for completeness. Closes gh-1904
* Datepicker: Fix typo in currentText in da localizationOskarNS2019-12-091-1/+1
| | | | | | | The term for "Today" in Danish is "I dag" not "Idag". This is a common misspelling in the Danish language. see https://dsn.dk/?retskriv=idag Dansk Sprognævn (DSN) is the authority over the Danish language. Closes gh-1862
* All: Use expr.pseudos instead of deprecated expr.filtersMaksymenkov Eugene2019-12-082-4/+4
| | | | | | See: https://github.com/jquery/jquery-migrate/blob/master/warnings.md#jqmigrate-jqueryexprfilters-is-deprecated-use-jqueryexprpseudos Closes gh-1887
* All: Migrate away from deprecated/removed Core APIsMichał Gołębiowski-Owczarek2019-12-0816-59/+72
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary of the changes: * Build: Add jQuery 3.2.0-3.4.1 to versions UI can be tested against * Build: Load jQuery & Migrate via HTTPS * Build: Add package-lock.json to .gitignore * Build: Update jQuery Migrate from 3.0.0 to 3.1.0 * Build: Allow to run tests against jQuery 3.x-git * Build: Fix formatting according to JSCS rules * Build: Disable JSCS for the inlined jQuery Color * All: Switch from $.isArray to Array.isArray (jQuery.isArray will be removed in jQuery 4.0) * All: Switch from `$.isFunction( x )` to `typeof x === "function"` (jQuery.isFunction will be removed in jQuery 4.0) * All: Inline jQuery.isWindow as it'll be removed in jQuery 4.0 * Effects: Fix a timing issue in a variable declaration. Previously, a jQuery object was created, chained & assigned to a variable that was then accessed in a callback used inside of this chained definition. Due to a timing difference in when the callback fired for the first time in latest jQuery master, it was being called before the variable was defined. * Tests: Make dialog & draggable unit tests less strict (newest jQuery returns fractional results in some cases, making comparisons fail when there's a tiny difference) * All: Migrate from $.trim to bare String.prototype.trim (jQuery.trim will be deprecated in jQuery 3.5) Closes gh-1901
* Datepicker: Fix first day of week for pt-PT localeHorus682017-05-311-1/+1
| | | | | Fixes #15195 Closes gh-1820
* Dialog: Fix shared event handler for modal dialogsScott González2017-05-171-15/+14
| | | | | | | | | The old logic worked when all widgets of the same type used the same event namespace. However, now that each instance has its own namespace, we cannot use `_on()` for shared event handlers. Fixes #15182 Closes gh-1817
* All: Remove uses of `jQuery.proxy()`Scott González2017-05-171-2/+2
| | | | | Ref #15160 Closes gh-1813
* All: Remove uses of `jQuery.camelCase()`Scott González2017-05-171-1/+7
| | | | | Ref #15160 Ref gh-1813
* Position: Increase scrollbar test div to handle larger scrollbarsScott González2017-05-041-3/+3
| | | | | Fixes #15106 Closes gh-1811
* Core: Fix JQMIGRATE warning about `jQuery.expr[":"]`Eirik Sletteberg2017-05-027-8/+20
| | | | | | | This commit polyfills `jQuery.expr.pseudos` for old versions of jQuery. Fixes #15185 Closes gh-1773
* Menu: Ignore mouse events triggered due to page scrollingScott González2017-05-021-0/+12
| | | | | Fixes #9356 Closes gh-1806
* Menu: Handle mouse movement mixed with keyboard navigationScott González2017-05-021-23/+33
| | | | | Fixes #9357 Closes gh-1805
* Menu: Don't focus dividers when wrapping via keyboard navigationScott González2017-05-021-11/+13
| | | | | Fixes #15157 Closes gh-1804
* Button: Fix backcompat when called on collection of mixed elementsAlexander Schmitz2017-05-021-14/+73
| | | | | Fixes #15109 Closes gh-1808
* Sortable: Fix various scrolling issuesA. Wells2017-05-021-129/+168
| | | | | | | | | | | | | | | | | | | * Created _scroll extension point and migrated scroll code from _mouseDrag * Cleaned up logic for scrolled * Fixed appendTo functionality to match documentation * Remove unnecessary function calls * Move set-up position functions to appropriate place * Base scrollParent on placeholder and not helper * Update scrollParent when switching containers Fixes #3173 Fixes #15165 Fixes #15166 Fixes #15167 Fixes #15168 Fixes #15169 Fixes #15170 Closes gh-1793
* Labels: Handle empty setsScott González2017-05-021-0/+4
| | | | Fixes #15184
* Menu: Close menus immediately on selection or click outsideScott González2017-04-251-2/+2
| | | | | Fixes #15034 Closes gh-1807
* Widget: Handle `Object.create(null)` for options objectsScott González2017-04-241-1/+2
| | | | | Fixes #15179 Closes gh-1809
* Widget: Improve `remove` event bindings for `classes` optionsScott González2017-04-191-5/+21
| | | | | | | | | Fixes #15078 Fixes #15082 Fixes #15095 Fixes #15136 Fixes #15152 Closes gh-1769
* Resizable: Keep user-provided handles on destroyKonstantin Dinev2017-04-171-3/+2
| | | | | Closes gh-1798 Ref gh-1795
* Datepicker: Corrections for Swedish localizationAlbert Johansson2017-03-011-7/+7
| | | | | | | | Months and weekdays should be in small caps in Swedish. https://sv.wikipedia.org/wiki/Versalisering Fixes #15142 Closes gh-1799
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-29 12:18:15 +0000