From 0c860b0d92f9959f6747f8c02e9671eb2fc561aa Mon Sep 17 00:00:00 2001 From: Michał Gołębiowski-Owczarek Date: Wed, 22 Jan 2020 16:44:34 +0100 Subject: All: Remove usage of jQuery positional selectors jQuery positional selectors () have been deprecated in [jQuery 3.4.0](https://blog.jquery.com/2019/04/10/jquery-3-4-0-released/) and they'll be removed in jQuery 4.0.0. This PR removes their usage. Most of the changes were possible without changing public API. However, dropping `:even` usage required a change to the [`header` option](https://api.jqueryui.com/accordion/#option-header) of the accordion widget. I made it an optional function; this will need to be documented. The polyfill for `.even()` & `.odd()` is added for jQuery <3.5.0. There was no usage of the :odd selector in the code but the `.odd()` method is also polyfilled for completeness. Closes gh-1904 --- tests/lib/bootstrap.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'tests/lib') diff --git a/tests/lib/bootstrap.js b/tests/lib/bootstrap.js index 27c1b610f..0134d1d03 100644 --- a/tests/lib/bootstrap.js +++ b/tests/lib/bootstrap.js @@ -172,8 +172,11 @@ function migrateUrl() { } } + var jQueryVersion = parseUrl().jquery; + // Load the jQuery fixes, if necessary - if ( parseFloat( parseUrl().jquery ) < 3 ) { + if ( !jQueryVersion || + ( jQueryVersion.indexOf( "git" ) === -1 && parseFloat( jQueryVersion ) < 4 ) ) { modules.unshift( "ui/jquery-1-7" ); } -- cgit v1.2.3