From 122b91374338b926e3f86ad6d7154dd4b98ef270 Mon Sep 17 00:00:00 2001 From: Jörn Zaefferer Date: Thu, 20 Feb 2014 17:54:48 +0100 Subject: Dialog: Work around subpixel issues in dialog resizable test Switching to checking the size of the content element. We should be checking the dimensions of the .ui-dialog element, but that currently fails in Chromium-based browsers. Once we start using box-sizing: border-box, we should try to revert this change. Ref #9845 --- tests/unit/dialog/dialog_test_helpers.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'tests/unit/dialog') diff --git a/tests/unit/dialog/dialog_test_helpers.js b/tests/unit/dialog/dialog_test_helpers.js index 64e8dbf6f..705eb3010 100644 --- a/tests/unit/dialog/dialog_test_helpers.js +++ b/tests/unit/dialog/dialog_test_helpers.js @@ -24,17 +24,20 @@ TestHelpers.dialog = { actualDY = offsetAfter.top - offsetBefore.top; ok( expectedDX - actualDX <= 1 && expectedDY - actualDY <= 1, "dragged[" + expectedDX + ", " + expectedDY + "] " + msg); }, + // TODO switch back to checking the size of the .ui-dialog element (var d) + // once we switch to using box-sizing: border-box (#9845) that should work fine + // using the element's dimensions to avoid subpixel errors shouldResize: function(element, dw, dh, msg) { var heightAfter, widthAfter, actual, expected, d = element.dialog("widget"), handle = $(".ui-resizable-se", d), - heightBefore = d.height(), - widthBefore = d.width(); + heightBefore = element.height(), + widthBefore = element.width(); TestHelpers.dialog.drag(element, handle, 50, 50); - heightAfter = d.height(); - widthAfter = d.width(); + heightAfter = element.height(); + widthAfter = element.width(); msg = msg ? msg + "." : ""; actual = { width: widthAfter, height: heightAfter }, -- cgit v1.2.3