From 0c860b0d92f9959f6747f8c02e9671eb2fc561aa Mon Sep 17 00:00:00 2001 From: Michał Gołębiowski-Owczarek Date: Wed, 22 Jan 2020 16:44:34 +0100 Subject: All: Remove usage of jQuery positional selectors jQuery positional selectors () have been deprecated in [jQuery 3.4.0](https://blog.jquery.com/2019/04/10/jquery-3-4-0-released/) and they'll be removed in jQuery 4.0.0. This PR removes their usage. Most of the changes were possible without changing public API. However, dropping `:even` usage required a change to the [`header` option](https://api.jqueryui.com/accordion/#option-header) of the accordion widget. I made it an optional function; this will need to be documented. The polyfill for `.even()` & `.odd()` is added for jQuery <3.5.0. There was no usage of the :odd selector in the code but the `.odd()` method is also polyfilled for completeness. Closes gh-1904 --- tests/visual/selectmenu/selectmenu.html | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'tests/visual/selectmenu/selectmenu.html') diff --git a/tests/visual/selectmenu/selectmenu.html b/tests/visual/selectmenu/selectmenu.html index 693885d25..0dbfc3882 100644 --- a/tests/visual/selectmenu/selectmenu.html +++ b/tests/visual/selectmenu/selectmenu.html @@ -89,10 +89,10 @@ $("#disable_option").on("click", function() { if (disable_option) { disable_option = false; - disabled4.find("option:eq(0)").attr("disabled", "disabled"); + disabled4.find( "option" ).eq( 0 ).attr("disabled", "disabled"); } else { disable_option = true; - disabled4.find("option:eq(0)").removeAttr("disabled"); + disabled4.find( "option" ).eq( 0 ).removeAttr("disabled"); } disabled4.selectmenu("refresh"); return false; @@ -101,10 +101,10 @@ $("#disable_optgroup").on("click", function() { if (disable_optgroup) { disable_optgroup = false; - disabled4.find("optgroup:eq(0)").attr("disabled", "disabled"); + disabled4.find( "optgroup" ).eq( 0 ).attr("disabled", "disabled"); } else { disable_optgroup = true; - disabled4.find("optgroup:eq(0)").removeAttr("disabled"); + disabled4.find( "optgroup" ).eq( 0 ).removeAttr("disabled"); } disabled4.selectmenu("refresh"); return false; -- cgit v1.2.3