From 4c9caa816906d53b989c65bd24c56147517eee82 Mon Sep 17 00:00:00 2001 From: Jörn Zaefferer Date: Thu, 15 Nov 2012 23:23:25 +0100 Subject: Dialog: Extract button pane creation into _createButtonPane --- ui/jquery.ui.dialog.js | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) (limited to 'ui/jquery.ui.dialog.js') diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js index d4f03af60..79aae52ab 100644 --- a/ui/jquery.ui.dialog.js +++ b/ui/jquery.ui.dialog.js @@ -123,16 +123,8 @@ $.widget("ui.dialog", { .addClass( "ui-dialog-content ui-widget-content" ) .appendTo( this.uiDialog ); - this._createTitlebar(); - - // TODO extract this one and the next into a _createButtonPane method - uiDialogButtonPane = ( this.uiDialogButtonPane = $( "
" ) ) - .addClass( "ui-dialog-buttonpane ui-widget-content ui-helper-clearfix" ); - - ( this.uiButtonSet = $( "
" ) ) - .addClass( "ui-dialog-buttonset" ) - .appendTo( uiDialogButtonPane ); - + this._createTitlebar(); + this._createButtonPane(); // TODO move into _createWrapper // We assume that any existing aria-describedby attribute means @@ -151,9 +143,6 @@ $.widget("ui.dialog", { this._makeResizable(); } - // TODO merge with _createButtonPane? - this._createButtons(); - this._isOpen = false; // prevent tabbing out of dialogs @@ -365,6 +354,17 @@ $.widget("ui.dialog", { }); }, + _createButtonPane: function() { + var uiDialogButtonPane = ( this.uiDialogButtonPane = $( "
" ) ) + .addClass( "ui-dialog-buttonpane ui-widget-content ui-helper-clearfix" ); + + this.uiButtonSet = $( "
" ) + .addClass( "ui-dialog-buttonset" ) + .appendTo( uiDialogButtonPane ); + + this._createButtons(); + }, + _createButtons: function() { var that = this, buttons = this.options.buttons; -- cgit v1.2.3