From 39229962316ddeeaa19b2c725ee32d46c38e687c Mon Sep 17 00:00:00 2001
From: jzaefferer <joern.zaefferer@gmail.com>
Date: Sat, 27 Mar 2010 01:47:42 +0100
Subject: Slider: Inlining _step method, was used only once

---
 ui/jquery.ui.slider.js | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

(limited to 'ui/jquery.ui.slider.js')

diff --git a/ui/jquery.ui.slider.js b/ui/jquery.ui.slider.js
index c392facd7..f0cc2ace1 100644
--- a/ui/jquery.ui.slider.js
+++ b/ui/jquery.ui.slider.js
@@ -152,7 +152,7 @@ $.widget("ui.slider", $.ui.mouse, {
 					break;
 			}
 
-			var curVal, newVal, step = self._step();
+			var curVal, newVal, step = self.options.step;
 			if (self.options.values && self.options.values.length) {
 				curVal = newVal = self.values(index);
 			} else {
@@ -526,11 +526,6 @@ $.widget("ui.slider", $.ui.mouse, {
 
 	},
 
-	_step: function() {
-		var step = this.options.step;
-		return step;
-	},
-
 	_value: function() {
 		//internal value getter
 		// _value() returns value trimmed by min and max
-- 
cgit v1.2.3


From b96ff11e3b30c93f5707d1299096b27a743974f8 Mon Sep 17 00:00:00 2001
From: jzaefferer <joern.zaefferer@gmail.com>
Date: Sat, 27 Mar 2010 01:49:56 +0100
Subject: Slider: Refactoring _valueMin and _valueMax methods, removing useless
 temporary variables

---
 ui/jquery.ui.slider.js | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

(limited to 'ui/jquery.ui.slider.js')

diff --git a/ui/jquery.ui.slider.js b/ui/jquery.ui.slider.js
index f0cc2ace1..bed4185e7 100644
--- a/ui/jquery.ui.slider.js
+++ b/ui/jquery.ui.slider.js
@@ -566,13 +566,11 @@ $.widget("ui.slider", $.ui.mouse, {
 	},
 
 	_valueMin: function() {
-		var valueMin = this.options.min;
-		return valueMin;
+		return this.options.min;
 	},
 
 	_valueMax: function() {
-		var valueMax = this.options.max;
-		return valueMax;
+		return this.options.max;
 	},
 	
 	_refreshValue: function() {
-- 
cgit v1.2.3


From 49411982c2ade2f678965b395a56e740a12d049e Mon Sep 17 00:00:00 2001
From: jzaefferer <joern.zaefferer@gmail.com>
Date: Sat, 27 Mar 2010 01:52:44 +0100
Subject: Slider: Refactoring _trimValue method to use more sane programming
 logic

---
 ui/jquery.ui.slider.js | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

(limited to 'ui/jquery.ui.slider.js')

diff --git a/ui/jquery.ui.slider.js b/ui/jquery.ui.slider.js
index bed4185e7..185fe809c 100644
--- a/ui/jquery.ui.slider.js
+++ b/ui/jquery.ui.slider.js
@@ -559,9 +559,12 @@ $.widget("ui.slider", $.ui.mouse, {
 	},
 	
 	_trimValue: function(val) {
-		if (val < this._valueMin()) val = this._valueMin();
-		if (val > this._valueMax()) val = this._valueMax();
-
+		if (val < this._valueMin()) {
+			return this._valueMin();
+		}
+		if (val > this._valueMax()) {
+			return this._valueMax();
+		}
 		return val;
 	},
 
-- 
cgit v1.2.3