From 4eff2a9cfa974692d3809ab8651dedcb1052f2a4 Mon Sep 17 00:00:00 2001 From: Felix Nagel Date: Fri, 30 Sep 2011 21:36:16 +0200 Subject: Selectmenu: change to _bind (follow up), improved anchor handling --- ui/jquery.ui.selectmenu.js | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) (limited to 'ui') diff --git a/ui/jquery.ui.selectmenu.js b/ui/jquery.ui.selectmenu.js index 79c3c1435..1aea9da01 100644 --- a/ui/jquery.ui.selectmenu.js +++ b/ui/jquery.ui.selectmenu.js @@ -137,6 +137,10 @@ $.widget( "ui.selectmenu", { } that._bind( that.list, { + 'click': function( event ) { + event.preventDefault(); + }, + // namespacing is needed (_bind should do the trick, but it doesnt) 'mouseenter.selectmenu': function() { that.hover = true; }, @@ -292,10 +296,11 @@ $.widget( "ui.selectmenu", { } else { li.append( $( "", { text: item.label, - href: '#', - click: function( event ) { - event.preventDefault(); - } + href: '#' + , + // click: function( event ) { + // event.preventDefault(); + // } }) ); } @@ -333,7 +338,8 @@ $.widget( "ui.selectmenu", { event.stopImmediatePropagation(); }, click: function( event ) { - event.stopImmediatePropagation(); + // needed to prevent browser from following the anchor + return false; }, keydown: function( event ) { switch (event.keyCode) { -- cgit v1.2.3