From f5d38e2e05bd54073c2bf8e8210b78b2cf2637d8 Mon Sep 17 00:00:00 2001 From: Paul Capron Date: Wed, 14 Oct 2020 23:53:11 +0200 Subject: Focusable: Fix handling of `visibility: collapse` "collapse" is similar to "hidden", with a slight difference in the case of tr/tbody/td/colgroup elements. See https://www.w3.org/TR/CSS22/visufx.html#visibility See https://www.w3.org/TR/CSS22/tables.html#dynamic-effects See https://developer.mozilla.org/en-US/docs/Web/CSS/visibility#Table_example "visibility: collapse" elements are always not focusable, though. Commit d3025968f34 introduced a regression by testing with `!== "hidden"` instead of `=== "visible"`. Closes gh-1843 --- ui/focusable.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ui') diff --git a/ui/focusable.js b/ui/focusable.js index b1a7b61e2..433474fcd 100644 --- a/ui/focusable.js +++ b/ui/focusable.js @@ -70,7 +70,7 @@ function visible( element ) { element = element.parent(); visibility = element.css( "visibility" ); } - return visibility !== "hidden"; + return visibility === "visible"; } $.extend( $.expr.pseudos, { -- cgit v1.2.3