diff options
| author | Oleg Gaidarenko <markelog@gmail.com> | 2014-06-16 01:26:49 +0400 |
|---|---|---|
| committer | Oleg Gaidarenko <markelog@gmail.com> | 2014-06-16 03:21:34 +0400 |
| commit | 76294e1e9e25665b22467c099ed406402f784e2a (patch) | |
| tree | c86fc3e16047472b6cb3bd56ecd2cd0d06bcc4b9 | |
| parent | d05f4bda1cc0b1ef76dce41a53c17f75c105a377 (diff) | |
| download | jquery-76294e1e9e25665b22467c099ed406402f784e2a.tar.gz jquery-76294e1e9e25665b22467c099ed406402f784e2a.zip | |
CSS: Do not throw on frame elements in FF
IE9-10 throws on elements created in popups (see #14150), FF meanwhile throws
on frame elements through "defaultView.getComputedStyle" (see #15098)
Use "defaultView" if in the popup which would fix IE issue,
use "window.getComputedStyle" which would fix FF issue.
And everybody wins, except performance, but who cares right?
Fixes #15098
Ref e488d985cfb10ab8c684bbc6a9b8ff3eae23bf83
| -rw-r--r-- | src/css/curCSS.js | 9 | ||||
| -rw-r--r-- | test/unit/css.js | 23 |
2 files changed, 31 insertions, 1 deletions
diff --git a/src/css/curCSS.js b/src/css/curCSS.js index 1f3b73428..9ab4f1126 100644 --- a/src/css/curCSS.js +++ b/src/css/curCSS.js @@ -11,7 +11,14 @@ var getStyles, curCSS, if ( window.getComputedStyle ) { getStyles = function( elem ) { - return elem.ownerDocument.defaultView.getComputedStyle( elem, null ); + // Support: IE<=11+, Firefox<=30+ (#15098, #14150) + // IE throws on elements created in popups + // FF meanwhile throws on frame elements through "defaultView.getComputedStyle" + if ( elem.ownerDocument.defaultView.opener ) { + return elem.ownerDocument.defaultView.getComputedStyle( elem, null ); + } + + return window.getComputedStyle( elem, null ); }; curCSS = function( elem, name, computed ) { diff --git a/test/unit/css.js b/test/unit/css.js index 28bc684ef..2051a2d00 100644 --- a/test/unit/css.js +++ b/test/unit/css.js @@ -1126,4 +1126,27 @@ test( "show() after hide() should always set display to initial value (#14750)", }); } })(); + +test( "Do not throw on frame elements from css method (#15098)", 1, function() { + var frameWin, frameDoc, + frameElement = document.createElement( "iframe" ), + frameWrapDiv = document.createElement( "div" ); + + frameWrapDiv.appendChild( frameElement ); + document.body.appendChild( frameWrapDiv ); + frameWin = frameElement.contentWindow; + frameDoc = frameWin.document; + frameDoc.open(); + frameDoc.write( "<!doctype html><html><body><div>Hi</div></body></html>" ); + frameDoc.close(); + + frameWrapDiv.style.display = "none"; + + try { + jQuery( frameDoc.body ).css( "direction" ); + ok( true, "It didn't throw" ); + } catch ( _ ) { + ok( false, "It did throw" ); + } +}); } |