diff options
| author | timmywil <tim.willison@thisismedium.com> | 2011-03-30 23:39:19 -0400 |
|---|---|---|
| committer | timmywil <tim.willison@thisismedium.com> | 2011-03-30 23:39:19 -0400 |
| commit | a807451a23577ad04140a32f7888e6c7b26a8838 (patch) | |
| tree | b77f245d7e11f2d83c8907de3182346d0a1b9f88 | |
| parent | 6c28a394c2174c51196cd9ac073b819fc79adb3b (diff) | |
| download | jquery-a807451a23577ad04140a32f7888e6c7b26a8838.tar.gz jquery-a807451a23577ad04140a32f7888e6c7b26a8838.zip | |
Fixes #7369 - Using an attribute selector for a non-existent attribute raised an exception on disconnected nodes
| -rw-r--r-- | src/traversing.js | 2 | ||||
| -rw-r--r-- | test/unit/traversing.js | 6 |
2 files changed, 6 insertions, 2 deletions
diff --git a/src/traversing.js b/src/traversing.js index fe2e33d88..468aa097f 100644 --- a/src/traversing.js +++ b/src/traversing.js @@ -112,7 +112,7 @@ jQuery.fn.extend({ } else { cur = cur.parentNode; - if ( !cur || !cur.ownerDocument || cur === context ) { + if ( !cur || !cur.ownerDocument || cur === context || cur.nodeType === 11 ) { break; } } diff --git a/test/unit/traversing.js b/test/unit/traversing.js index f5108bdef..4cccd650f 100644 --- a/test/unit/traversing.js +++ b/test/unit/traversing.js @@ -124,7 +124,7 @@ test("filter(jQuery)", function() { }) test("closest()", function() { - expect(11); + expect(13); same( jQuery("body").closest("body").get(), q("body"), "closest(body)" ); same( jQuery("body").closest("html").get(), q("html"), "closest(html)" ); same( jQuery("body").closest("div").get(), [], "closest(div)" ); @@ -144,6 +144,10 @@ test("closest()", function() { // Test on disconnected node equals( jQuery("<div><p></p></div>").find("p").closest("table").length, 0, "Make sure disconnected closest work." ); + + // Bug #7369 + equals( jQuery('<div foo="bar"></div>').closest('[foo]').length, 1, "Disconnected nodes with attribute selector" ); + equals( jQuery('<div>text</div>').closest('[lang]').length, 0, "Disconnected nodes with text and non-existent attribute selector" ); }); test("closest(Array)", function() { |