diff options
author | jeresig <jeresig@gmail.com> | 2010-03-05 00:07:57 -0500 |
---|---|---|
committer | jeresig <jeresig@gmail.com> | 2010-03-05 00:07:57 -0500 |
commit | 2c08004f6d4e7f11a875190e132d204a25cb9418 (patch) | |
tree | 4e40050dbe85f23e0e5f52feabd9d5544fe5b78a | |
parent | 9584e908a2daa2a72bd738302dba7cfd0656dbdf (diff) | |
download | jquery-2c08004f6d4e7f11a875190e132d204a25cb9418.tar.gz jquery-2c08004f6d4e7f11a875190e132d204a25cb9418.zip |
Attempted to fix #6227, not entirely sure if it's a problem as I'm having a hard time reproducing it. Regardless, the change is harmless and potentially even speeds up appendTo, etc. slightly.
-rw-r--r-- | src/manipulation.js | 2 | ||||
-rw-r--r-- | test/unit/manipulation.js | 10 |
2 files changed, 10 insertions, 2 deletions
diff --git a/src/manipulation.js b/src/manipulation.js index 7dc813689..13f5ec688 100644 --- a/src/manipulation.js +++ b/src/manipulation.js @@ -442,7 +442,7 @@ jQuery.each({ } else { for ( var i = 0, l = insert.length; i < l; i++ ) { var elems = (i > 0 ? this.clone(true) : this).get(); - jQuery.fn[ original ].apply( jQuery(insert[i]), elems ); + jQuery.fn[ original ].call( jQuery(insert[i]), elems ); ret = ret.concat( elems ); } diff --git a/test/unit/manipulation.js b/test/unit/manipulation.js index d88400d1f..e86eb3b83 100644 --- a/test/unit/manipulation.js +++ b/test/unit/manipulation.js @@ -376,7 +376,7 @@ test("append(Function) with incoming value", function() { }); test("appendTo(String|Element|Array<Element>|jQuery)", function() { - expect(14); + expect(16); var defaultText = 'Try them out:' jQuery('<b>buga</b>').appendTo('#first'); @@ -384,6 +384,14 @@ test("appendTo(String|Element|Array<Element>|jQuery)", function() { equals( jQuery('<option value="appendTest">Append Test</option>').appendTo('#select3').parent().find('option:last-child').attr('value'), 'appendTest', 'Appending html options to select element'); reset(); + var l = jQuery("#first").children().length + 3; + jQuery("body").map(function(){ + return jQuery("<strong></strong><b></b><b></b>").get(); + }).appendTo("p"); + equals( jQuery("#first").children().length, l, "Make sure the elements were inserted." ); + equals( jQuery("#first").children().last()[0].nodeName.toLowerCase(), "b", "Verify the last element." ); + + reset(); var expected = "This link has class=\"blog\": Simon Willison's WeblogTry them out:"; jQuery(document.getElementById('first')).appendTo('#sap'); equals( expected, jQuery('#sap').text(), "Check for appending of element" ); |