aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohn Resig <jeresig@gmail.com>2009-07-19 13:32:53 +0000
committerJohn Resig <jeresig@gmail.com>2009-07-19 13:32:53 +0000
commit48e9a3999596c2ee1f4470a78637de8f27e3b219 (patch)
tree8f4c68775a0645be21cce8d49cd6959d000bfb00
parent0d5c3a68a092401089c9242bdafdb1b2534feb6a (diff)
downloadjquery-48e9a3999596c2ee1f4470a78637de8f27e3b219.tar.gz
jquery-48e9a3999596c2ee1f4470a78637de8f27e3b219.zip
Standardize on using .nodeName in place of .tagName. Fixes jQuery bug #4923.
-rw-r--r--src/ajax.js2
-rw-r--r--src/attributes.js4
-rw-r--r--src/fx.js10
-rw-r--r--src/offset.js6
-rw-r--r--src/selector.js2
5 files changed, 12 insertions, 12 deletions
diff --git a/src/ajax.js b/src/ajax.js
index 2e4c740da..a41de4cdc 100644
--- a/src/ajax.js
+++ b/src/ajax.js
@@ -481,7 +481,7 @@ jQuery.extend({
xml = type == "xml" || !type && ct && ct.indexOf("xml") >= 0,
data = xml ? xhr.responseXML : xhr.responseText;
- if ( xml && data.documentElement.tagName == "parsererror" ) {
+ if ( xml && data.documentElement.nodeName == "parsererror" ) {
throw "parsererror";
}
diff --git a/src/attributes.js b/src/attributes.js
index 041bb29fc..de1d331b0 100644
--- a/src/attributes.js
+++ b/src/attributes.js
@@ -192,7 +192,7 @@ jQuery.extend({
if (!elem || elem.nodeType == 3 || elem.nodeType == 8)
return undefined;
- var notxml = !elem.tagName || !jQuery.isXMLDoc( elem ),
+ var notxml = elem.nodeType !== 1 || !jQuery.isXMLDoc( elem ),
// Whether we are setting (or getting)
set = value !== undefined;
@@ -200,7 +200,7 @@ jQuery.extend({
name = notxml && jQuery.props[ name ] || name;
// Only do all the following if this is a node (faster for style)
- if ( elem.tagName ) {
+ if ( elem.nodeType === 1 ) {
// These attributes require special treatment
var special = /href|src|style/.test( name );
diff --git a/src/fx.js b/src/fx.js
index 65bb3f143..8025de4d2 100644
--- a/src/fx.js
+++ b/src/fx.js
@@ -28,12 +28,12 @@ jQuery.fn.extend({
this[i].style.display = old || "";
if ( jQuery.css(this[i], "display") === "none" ) {
- var tagName = this[i].tagName, display;
+ var nodeName = this[i].nodeName, display;
- if ( elemdisplay[ tagName ] ) {
- display = elemdisplay[ tagName ];
+ if ( elemdisplay[ nodeName ] ) {
+ display = elemdisplay[ nodeName ];
} else {
- var elem = jQuery("<" + tagName + " />").appendTo("body");
+ var elem = jQuery("<" + nodeName + " />").appendTo("body");
display = elem.css("display");
if ( display === "none" )
@@ -41,7 +41,7 @@ jQuery.fn.extend({
elem.remove();
- elemdisplay[ tagName ] = display;
+ elemdisplay[ nodeName ] = display;
}
jQuery.data(this[i], "olddisplay", display);
diff --git a/src/offset.js b/src/offset.js
index 6e22ce30e..3f616baa1 100644
--- a/src/offset.js
+++ b/src/offset.js
@@ -39,7 +39,7 @@ if ( "getBoundingClientRect" in document.documentElement ) {
top += elem.offsetTop;
left += elem.offsetLeft;
- if ( jQuery.offset.doesNotAddBorder && !(jQuery.offset.doesAddBorderForTableAndCells && /^t(able|d|h)$/i.test(elem.tagName)) ) {
+ if ( jQuery.offset.doesNotAddBorder && !(jQuery.offset.doesAddBorderForTableAndCells && /^t(able|d|h)$/i.test(elem.nodeName)) ) {
top += parseFloat( computedStyle.borderTopWidth ) || 0;
left += parseFloat( computedStyle.borderLeftWidth ) || 0;
}
@@ -127,7 +127,7 @@ jQuery.fn.extend({
// Get correct offsets
offset = this.offset(),
- parentOffset = /^body|html$/i.test(offsetParent[0].tagName) ? { top: 0, left: 0 } : offsetParent.offset();
+ parentOffset = /^body|html$/i.test(offsetParent[0].nodeName) ? { top: 0, left: 0 } : offsetParent.offset();
// Subtract element margins
// note: when an element has margin: auto the offsetLeft and marginLeft
@@ -149,7 +149,7 @@ jQuery.fn.extend({
offsetParent: function() {
return this.map(function(){
var offsetParent = this.offsetParent || document.body;
- while ( offsetParent && (!/^body|html$/i.test(offsetParent.tagName) && jQuery.css(offsetParent, 'position') === 'static') ) {
+ while ( offsetParent && (!/^body|html$/i.test(offsetParent.nodeName) && jQuery.css(offsetParent, 'position') === 'static') ) {
offsetParent = offsetParent.offsetParent;
}
return offsetParent;
diff --git a/src/selector.js b/src/selector.js
index a7d94c39d..c6fc0255a 100644
--- a/src/selector.js
+++ b/src/selector.js
@@ -978,7 +978,7 @@ jQuery.expr[":"] = jQuery.expr.filters;
Sizzle.selectors.filters.hidden = function(elem){
var width = elem.offsetWidth, height = elem.offsetHeight,
- force = /^tr$/i.test( elem.tagName ); // ticket #4512
+ force = /^tr$/i.test( elem.nodeName ); // ticket #4512
return ( width === 0 && height === 0 && !force ) ?
true :
( width !== 0 && height !== 0 && !force ) ?