diff options
| author | Timmy Willison <timmywillisn@gmail.com> | 2015-01-30 12:22:25 -0800 |
|---|---|---|
| committer | Timmy Willison <timmywillisn@gmail.com> | 2015-01-30 12:22:31 -0800 |
| commit | a76c7812366e7e45ea29969db72d90261ef87af5 (patch) | |
| tree | 3ba35392b461fd36b4ee465e9b7f5a7ca84b7a6c | |
| parent | e0673dfedb9ad07d8e68f28a54453b975c412c33 (diff) | |
| download | jquery-a76c7812366e7e45ea29969db72d90261ef87af5.tar.gz jquery-a76c7812366e7e45ea29969db72d90261ef87af5.zip | |
Release: remove sourcemap comment from all copies of minified file
Fixes gh-1707
| -rw-r--r-- | Gruntfile.js | 2 | ||||
| -rw-r--r-- | build/release/cdn.js | 6 | ||||
| -rw-r--r-- | build/tasks/sourcemap.js | 13 | ||||
| -rw-r--r-- | package.json | 3 |
4 files changed, 15 insertions, 9 deletions
diff --git a/Gruntfile.js b/Gruntfile.js index 38e5d4661..1b2dda38d 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -161,7 +161,7 @@ module.exports = function( grunt ) { grunt.registerTask( "test", [ "test_fast" ] ); // Short list as a high frequency watch task - grunt.registerTask( "dev", [ "build:*:*", "lint", "uglify", "dist:*" ] ); + grunt.registerTask( "dev", [ "build:*:*", "lint", "uglify", "remove_map_comment", "dist:*" ] ); grunt.registerTask( "default", [ "dev", "test_fast", "compare_size" ] ); }; diff --git a/build/release/cdn.js b/build/release/cdn.js index 8b0658812..6c497ee0b 100644 --- a/build/release/cdn.js +++ b/build/release/cdn.js @@ -44,12 +44,6 @@ function makeReleaseCopies( Release ) { "\"file\":\"" + unpathedFile.replace( /\.min\.map/, ".min.js" ) + "\",\"sources\":[\"" + unpathedFile.replace( /\.min\.map/, ".js" ) + "\"]" ); fs.writeFileSync( releaseFile, text ); - } else if ( /\.min\.js$/.test( releaseFile ) ) { - // Remove the source map comment; it causes way too many problems. - // Keep the map file in case DevTools allow manual association. - text = fs.readFileSync( builtFile, "utf8" ) - .replace( /\/\/# sourceMappingURL=\S+/, "" ); - fs.writeFileSync( releaseFile, text ); } else if ( builtFile !== releaseFile ) { shell.cp( "-f", builtFile, releaseFile ); } diff --git a/build/tasks/sourcemap.js b/build/tasks/sourcemap.js new file mode 100644 index 000000000..5f4d5232f --- /dev/null +++ b/build/tasks/sourcemap.js @@ -0,0 +1,13 @@ +var fs = require( "fs" ); + +module.exports = function( grunt ) { + var minLoc = Object.keys( grunt.config( "uglify.all.files" ) )[ 0 ]; + grunt.registerTask( "remove_map_comment", function() { + // Remove the source map comment; it causes way too many problems. + // The map file is still generated for manual associations + // https://github.com/jquery/jquery/issues/1707 + var text = fs.readFileSync( minLoc, "utf8" ) + .replace( /\/\/# sourceMappingURL=\S+/, "" ); + fs.writeFileSync( minLoc, text ); + }); +}; diff --git a/package.json b/package.json index bbeea08be..3ba5d8bfb 100644 --- a/package.json +++ b/package.json @@ -35,7 +35,7 @@ "grunt-cli": "0.1.13", "grunt-compare-size": "0.4.0", "grunt-contrib-jshint": "0.10.0", - "grunt-contrib-uglify": "0.6.0", + "grunt-contrib-uglify": "0.7.0", "grunt-contrib-watch": "0.6.1", "grunt-git-authors": "2.0.1", "grunt-jscs-checker": "0.8.1", @@ -61,7 +61,6 @@ "Tests", "Build", "Release", - "Core", "Ajax", "Attributes", |