diff options
| author | Ariel Flesler <aflesler@gmail.com> | 2009-07-16 15:16:44 +0000 |
|---|---|---|
| committer | Ariel Flesler <aflesler@gmail.com> | 2009-07-16 15:16:44 +0000 |
| commit | a38a5cd531a328319f8b7f3f33a84044b54591ce (patch) | |
| tree | 56359ea7f4ef5f35b097016305f6968ecb2cbf60 | |
| parent | 991d039b62f5dfcb9e3d99fe28212a6874e8f5c7 (diff) | |
| download | jquery-a38a5cd531a328319f8b7f3f33a84044b54591ce.tar.gz jquery-a38a5cd531a328319f8b7f3f33a84044b54591ce.zip | |
jquery core: Simplifying isEmptyObject() and adding tests.
| -rw-r--r-- | src/core.js | 6 | ||||
| -rw-r--r-- | test/unit/core.js | 10 |
2 files changed, 13 insertions, 3 deletions
diff --git a/src/core.js b/src/core.js index 74b9fee39..a71656d06 100644 --- a/src/core.js +++ b/src/core.js @@ -292,9 +292,9 @@ jQuery.extend({ }, isEmptyObject: function( obj ) { - var name = ""; - for(name in obj) break; - return !name; + for(var name in obj) + return false; + return true; }, // check if an element is in a (or is an) XML document diff --git a/test/unit/core.js b/test/unit/core.js index a6f490c47..8aa883aed 100644 --- a/test/unit/core.js +++ b/test/unit/core.js @@ -599,3 +599,13 @@ test("jQuery.makeArray", function(){ ok( jQuery.makeArray(document.getElementById('form')).length >= 13, "Pass makeArray a form (treat as elements)" ); }); + +test("jQuery.isEmptyObject", function(){ + expect(2); + + equals(true, jQuery.isEmptyObject({}), "isEmptyObject on empty object literal" ); + equals(false, jQuery.isEmptyObject({a:1}), "isEmptyObject on non-empty object literal" ); + + // What about this ? + // equals(true, jQuery.isEmptyObject(null), "isEmptyObject on null" ); +});
\ No newline at end of file |