aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjaubourg <j@ubourg.net>2011-01-19 17:06:33 +0100
committerjaubourg <j@ubourg.net>2011-01-19 17:06:33 +0100
commitbd6eb849eeb96298bfbd3de71a27cfcbe32bc772 (patch)
tree38846f47bbcd35042d240ed3856fdc0a55ef8739
parent92c3d87a9cdd611af06e46a5e66a4876c2be5ed0 (diff)
downloadjquery-bd6eb849eeb96298bfbd3de71a27cfcbe32bc772.tar.gz
jquery-bd6eb849eeb96298bfbd3de71a27cfcbe32bc772.zip
Revised how context is determined and removed unnecessary "parameter as variable" trick.
-rw-r--r--src/ajax.js22
1 files changed, 10 insertions, 12 deletions
diff --git a/src/ajax.js b/src/ajax.js
index 43bab7c3d..b9033587d 100644
--- a/src/ajax.js
+++ b/src/ajax.js
@@ -233,8 +233,7 @@ jQuery.extend({
},
// Main method
- // (s is used internally)
- ajax: function( url , options , s ) {
+ ajax: function( url , options ) {
// Handle varargs
if ( arguments.length === 1 ) {
@@ -248,19 +247,14 @@ jQuery.extend({
// Get the url if provided separately
options.url = url || options.url;
- // Create the final options object
- s = jQuery.extend( true , {} , jQuery.ajaxSettings , options );
-
- // We force the original context
- // (plain objects used as context get extended)
- s.context = options.context;
-
- var // jQuery lists
+ var // Create the final options object
+ s = jQuery.extend( true , {} , jQuery.ajaxSettings , options ),
+ // jQuery lists
jQuery_lastModified = jQuery.lastModified,
jQuery_etag = jQuery.etag,
// Callbacks contexts
- callbackContext = s.context || s,
- globalEventContext = s.context ? jQuery( s.context ) : jQuery.event,
+ callbackContext = options.context || s.context || s,
+ globalEventContext = callbackContext === s ? jQuery.event : jQuery( callbackContext ),
// Deferreds
deferred = jQuery.Deferred(),
completeDeferred = jQuery._Deferred(),
@@ -337,6 +331,10 @@ jQuery.extend({
}
};
+ // We force the original context
+ // (plain objects used as context get extended)
+ s.context = options.context;
+
// Callback for when everything is done
// It is defined here because jslint complains if it is declared
// at the end of the function (which would be more logical and readable)