diff options
author | jeresig <jeresig@gmail.com> | 2009-12-22 02:00:46 -0500 |
---|---|---|
committer | jeresig <jeresig@gmail.com> | 2009-12-22 02:00:46 -0500 |
commit | 1e64d581830f735999b60939eccf9bcdcb2e9ef9 (patch) | |
tree | b4e87926e761642434ee8c5d9ca03874811e08a9 /src/attributes.js | |
parent | 1b67aaee74c9b683ac31893b40077abd62e6d8c6 (diff) | |
download | jquery-1e64d581830f735999b60939eccf9bcdcb2e9ef9.tar.gz jquery-1e64d581830f735999b60939eccf9bcdcb2e9ef9.zip |
Make sure that the correct value is being pulled from checkboxes in Webkit. Fixes #5699.
Diffstat (limited to 'src/attributes.js')
-rw-r--r-- | src/attributes.js | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/src/attributes.js b/src/attributes.js index 663d660f4..794da70ff 100644 --- a/src/attributes.js +++ b/src/attributes.js @@ -4,7 +4,8 @@ var rclass = /[\n\t]/g, rspecialurl = /href|src|style/, rtype = /(button|input)/i, rfocusable = /(button|input|object|select|textarea)/i, - rclickable = /^(a|area)$/i; + rclickable = /^(a|area)$/i, + rradiocheck = /radio|checkbox/; jQuery.fn.extend({ attr: function( name, value ) { @@ -127,6 +128,12 @@ jQuery.fn.extend({ return values; } + // Handle the case where in Webkit "" is returned instead of "on" if a value isn't specified + if ( rradiocheck.test( elem.type ) && !jQuery.support.checkOn ) { + return elem.getAttribute("value") === null ? "on" : elem.value; + } + + // Everything else, we just grab the value return (elem.value || "").replace(rreturn, ""); @@ -157,8 +164,8 @@ jQuery.fn.extend({ return; } - if ( jQuery.isArray(val) && /radio|checkbox/.test( this.type ) ) { - this.checked = jQuery.inArray( this.value, val ) >= 0; + if ( jQuery.isArray(val) && rradiocheck.test( this.type ) ) { + this.checked = jQuery.inArray( jQuery(this).val(), val ) >= 0; } else if ( jQuery.nodeName( this, "select" ) ) { var values = jQuery.makeArray(val); |